third_party/WebKit/Source/modules/notifications/NotificationAction.idl - Issue 1855443002: Implement receiving side of web notification inline replies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationAction.idl

Issue 1855443002: Implement receiving side of web notification inline replies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments & Tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html ('K') | « third_party/WebKit/Source/modules/notifications/Notification.cpp ('k') | third_party/WebKit/Source/modules/notifications/NotificationData.cpp » ('j') | third_party/WebKit/public/platform/modules/notifications/WebNotificationAction.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationAction.idl

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationAction.idl b/third_party/WebKit/Source/modules/notifications/NotificationAction.idl

index be78856c3bc5028caa5b6d13f526f6d41ce61853..5de51f9517846d2d073302e35e31b9bf6c92d2cb 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationAction.idl

+++ b/third_party/WebKit/Source/modules/notifications/NotificationAction.idl

@@ -4,8 +4,15 @@

// https://notifications.spec.whatwg.org/#dictdef-notificationaction

+[RuntimeEnabled=NotificationInlineReplies] enum NotificationActionType {

jbroman 2016/04/05 15:12:48 FYI, making an enum RuntimeEnabled is a no-op as f

Nina 2016/04/05 16:10:01 Ah! I'll leave it like this for now and follow the

+ "button",

+ "text"

+};

dictionary NotificationAction {

+ [RuntimeEnabled=NotificationInlineReplies] NotificationActionType type = "button";

required DOMString action;

required DOMString title;

[RuntimeEnabled=NotificationActionIcons] USVString icon;

+ [RuntimeEnabled=NotificationInlineReplies] DOMString? placeholder = null;

};