Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationAction.idl

Issue 1855443002: Implement receiving side of web notification inline replies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/notifications/NotificationAction.idl
diff --git a/third_party/WebKit/Source/modules/notifications/NotificationAction.idl b/third_party/WebKit/Source/modules/notifications/NotificationAction.idl
index be78856c3bc5028caa5b6d13f526f6d41ce61853..6dc56945a66773fa7a8a4de2210bae482535927d 100644
--- a/third_party/WebKit/Source/modules/notifications/NotificationAction.idl
+++ b/third_party/WebKit/Source/modules/notifications/NotificationAction.idl
@@ -4,8 +4,15 @@
// https://notifications.spec.whatwg.org/#dictdef-notificationaction
+[RuntimeEnabled=NotificationInlineReplies] enum NotificationActionType {
+ "button",
+ "text"
+};
+
dictionary NotificationAction {
required DOMString action;
required DOMString title;
[RuntimeEnabled=NotificationActionIcons] USVString icon;
+ [RuntimeEnabled=NotificationInlineReplies] NotificationActionType type = "button";
+ [RuntimeEnabled=NotificationInlineReplies] DOMString? placeholder;
Michael van Ouwerkerk 2016/04/05 10:06:55 How is null expressed in our implementation, what
Nina 2016/04/05 13:28:22 I modified the existing code to account for it.
};

Powered by Google App Engine
This is Rietveld 408576698