Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 10960007: Turn on Clang checking for cc directory (Closed)

Created:
8 years, 3 months ago by enne (OOO)
Modified:
8 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews, pam+watch_chromium.org, jamesr
Visibility:
Public.

Description

Turn on Clang checking for cc directory Once this sticks, the setting can be removed entirely. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158017

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/clang/scripts/plugin_flags.sh View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
enne (OOO)
This depends on these two patches landing first: https://codereview.chromium.org/10942040/ https://codereview.chromium.org/10947047/
8 years, 3 months ago (2012-09-19 23:40:35 UTC) #1
Nico
lgtm!
8 years, 3 months ago (2012-09-19 23:43:58 UTC) #2
Nico
On 2012/09/19 23:43:58, Nico wrote: > lgtm! (Are you going to send a CL to ...
8 years, 3 months ago (2012-09-19 23:44:28 UTC) #3
enne (OOO)
I was planning on it.
8 years, 3 months ago (2012-09-19 23:45:21 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-21 16:48:07 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698