chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm - Issue 1855423003: Interpret '?' and Ctrl-K or Ctrl-E as putting omnibox in keyword search mode for Default Search Pro…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

Issue 1855423003: Interpret '?' and Ctrl-K or Ctrl-E as putting omnibox in keyword search mode for Default Search Pro… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed compilation on Mac and removed forced query unit tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autocomplete/autocomplete_browsertest.cc ('K') | « chrome/browser/autocomplete/search_provider_unittest.cc ('k') | chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h » ('j') | components/omnibox/browser/omnibox_edit_model.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

diff --git a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

index bc3aeeb1ac6fd54b01e7299f60967eb0e28d6767..c25185142dc7e05c9c05dfeb65e424b8659ab7ff 100644

--- a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

+++ b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

@@ -175,7 +175,7 @@ void LocationBarViewMac::FocusLocation(bool select_all) {

}

void LocationBarViewMac::FocusSearch() {

- omnibox_view_->SetForcedQuery();

+ omnibox_view_->EnterKeywordModeForDefaultSearchProvider();

}

void LocationBarViewMac::UpdateContentSettingsIcons() {