Interpret '?' and Ctrl-K or Ctrl-E as putting omnibox in keyword search mode for Default Search Pro…

components/omnibox/browser/omnibox_edit_model.h

Index: components/omnibox/browser/omnibox_edit_model.h
diff --git a/components/omnibox/browser/omnibox_edit_model.h b/components/omnibox/browser/omnibox_edit_model.h
index 4c567c2b70e3cf59308c75253747641e020aaaf6..32e662f12b19af31cc9c5558472f62b813350e4e 100644
--- a/components/omnibox/browser/omnibox_edit_model.h
+++ b/components/omnibox/browser/omnibox_edit_model.h
@@ -36,11 +36,13 @@ class Rect;
 
 // Reasons why the Omnibox could change into keyword mode.
 // These numeric values are used in UMA logs; do not change them.
-enum EnteredKeywordModeMethod {
-  ENTERED_KEYWORD_MODE_VIA_TAB = 0,
-  ENTERED_KEYWORD_MODE_VIA_SPACE_AT_END = 1,
-  ENTERED_KEYWORD_MODE_VIA_SPACE_IN_MIDDLE = 2,
-  ENTERED_KEYWORD_MODE_NUM_ITEMS
+enum KeywordModeEntryMethod {
+  METHOD_TAB = 0,
+  METHOD_SPACE_AT_END = 1,
+  METHOD_SPACE_IN_MIDDLE = 2,
+  METHOD_KEYBOARD_SHORTCUT = 3,
+  METHOD_QUESTION_MARK = 4,
+  KEYWORD_MODE_ENTRY_METHOD_NUM_ITEMS

[Peter Kasting, 2016/04/15 00:58:55]

Any particular reason to not make this an enum class?  The names are better than
before, but it still seems like KeywordModeEntryMethod::SPACE_AT_END or
KeywordModeEntryMethod::NUM_ITEMS buy maximum safety and clarity.

[Tom (Use chromium acct), 2016/04/15 05:20:52]

Done. The enum class was breaking UMA_HISTOGRAM_ENUMERATION due to its strong
typing, but I added (int) casts to silence the errors

 };
 
 class OmniboxEditModel {
@@ -59,6 +61,7 @@ class OmniboxEditModel {
           const base::string16& gray_text,
           const base::string16& keyword,
           bool is_keyword_hint,
+          KeywordModeEntryMethod keyword_mode_entry_method,
           bool url_replacement_enabled,
           OmniboxFocusState focus_state,
           FocusSource focus_source,
@@ -71,6 +74,7 @@ class OmniboxEditModel {
     const base::string16 gray_text;
     const base::string16 keyword;
     const bool is_keyword_hint;
+    KeywordModeEntryMethod keyword_mode_entry_method;
     bool url_replacement_enabled;
     OmniboxFocusState focus_state;
     FocusSource focus_source;
@@ -236,10 +240,14 @@ class OmniboxEditModel {
   }
 
   // Accepts the current keyword hint as a keyword. It always returns true for
-  // caller convenience. |entered_method| indicates how the use entered
-  // keyword mode. This parameter is only used for metrics/logging; it's not
-  // used to change user-visible behavior.
-  bool AcceptKeyword(EnteredKeywordModeMethod entered_method);
+  // caller convenience. |entered_method| indicates how the user entered
+  // keyword mode.
+  bool AcceptKeyword(KeywordModeEntryMethod keyword_mode_entry_method);
+
+  // Sets the current keyword to that of the user's default search provider and
+  // updates the view so the user sees the keyword chip in the omnibox.
+  void EnterKeywordModeForDefaultSearchProvider(
+      KeywordModeEntryMethod keyword_mode_entry_method);
 
   // Accepts the current temporary text as the user text.
   void AcceptTemporaryTextAsUserText();
@@ -335,6 +343,7 @@ class OmniboxEditModel {
                              size_t selection_end,
                              bool selection_differs,
                              bool text_differs,
+                             bool keyword_differs,
                              bool just_deleted_text,
                              bool allow_keyword_ui_change);
 
@@ -508,6 +517,11 @@ class OmniboxEditModel {
   bool just_deleted_text_;
   base::string16 inline_autocomplete_text_;
 
+  // Set when the user is in the process of exiting keyword mode.  This is
+  // useful to ensure we don't toggle back into keyword mode in the process of
+  // handling the current event.
+  bool clearing_keyword_;
+
   // Used by OnPopupDataChanged to keep track of whether there is currently a
   // temporary text.
   //
@@ -546,6 +560,11 @@ class OmniboxEditModel {
   // keyword_ to show a "Press <tab> to search" sort of hint.
   bool is_keyword_hint_;
 
+  // Indicates how the user entered keyword mode if the user is actually in
+  // keyword mode.  Otherwise, the value of this variable is undefined.  This
+  // is used to restore the user's search terms upon a call to ClearKeyword().
+  KeywordModeEntryMethod keyword_mode_entry_method_;
+
   // This is needed to properly update the SearchModel state when the user
   // presses escape.
   bool in_revert_;