components/omnibox/browser/shortcuts_provider.cc - Issue 1855423003: Interpret '?' and Ctrl-K or Ctrl-E as putting omnibox in keyword search mode for Default Search Pro…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/shortcuts_provider.cc

Issue 1855423003: Interpret '?' and Ctrl-K or Ctrl-E as putting omnibox in keyword search mode for Default Search Pro… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed forced queries using '?'. Removed Ctrl-K preserving the user's keyword if they're already … Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/omnibox/browser/omnibox_view.h ('K') | « components/omnibox/browser/search_suggestion_parser.cc ('k') | components/search_engines/template_url_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/omnibox/browser/shortcuts_provider.cc

diff --git a/components/omnibox/browser/shortcuts_provider.cc b/components/omnibox/browser/shortcuts_provider.cc

index 22ee0c71543b97dc00a86e9acc4582fa098805e2..f3e457ce89fde9dd8a15e2d45dadaf4cb767206f 100644

--- a/components/omnibox/browser/shortcuts_provider.cc

+++ b/components/omnibox/browser/shortcuts_provider.cc

@@ -71,7 +71,6 @@ void ShortcutsProvider::Start(const AutocompleteInput& input,

if (input.from_omnibox_focus() ||

(input.type() == metrics::OmniboxInputType::INVALID) ||

- (input.type() == metrics::OmniboxInputType::FORCED_QUERY) ||

input.text().empty() || !initialized_)

return;