Interpret '?' and Ctrl-K or Ctrl-E as putting omnibox in keyword search mode for Default Search Pro…

components/omnibox/browser/omnibox_view.h

Index: components/omnibox/browser/omnibox_view.h
diff --git a/components/omnibox/browser/omnibox_view.h b/components/omnibox/browser/omnibox_view.h
index f092f5281be9cfa38bd7cdfa8822264fa1d04dcc..3f449e836ad3c121a0f9d7725a445ab56720bc2d 100644
--- a/components/omnibox/browser/omnibox_view.h
+++ b/components/omnibox/browser/omnibox_view.h
@@ -98,13 +98,9 @@ class OmniboxView {
                                         bool update_popup,
                                         bool notify_text_changed) = 0;
 
-  // Sets the edit to forced query mode.  Practically speaking, this means that
-  // if the edit is not in forced query mode, its text is set to "?" with the
-  // cursor at the end, and if the edit is in forced query mode (its first
-  // non-whitespace character is '?'), the text after the '?' is selected.
-  //
-  // In the future we should display the search engine UI for the default engine
-  // rather than '?'.
+  // Transitions the user into keyword mode with their default search provider,
+  // preserving the user's text if they already typed in a query.  Selects the
+  // user's text if they're already in keyword mode.

[Peter Kasting, 2016/04/13 02:52:16]

Doesn't this select the text regardless?  (Which is what it should do, I think.)

[Tom (Use chromium acct), 2016/04/13 23:37:41]

Done.

   virtual void SetForcedQuery() = 0;

[Peter Kasting, 2016/04/13 02:52:16]

Nit: This function name should be changed as "forced query" isn't a meaningful
concept anymore; maybe this should also be named
EnterKeywordModeForDefaultSearchProvider()?

[Tom (Use chromium acct), 2016/04/13 23:37:41]

I Agree. Done.

 
   // Returns true if all text is selected or there is no text at all.