Interpret '?' and Ctrl-K or Ctrl-E as putting omnibox in keyword search mode for Default Search Pro…

components/omnibox/browser/omnibox_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file defines the interface class OmniboxView.  Each toolkit will
 // implement the edit view differently, so that code is inherently platform
 // specific.  However, the OmniboxEditModel needs to do some communication with
 // the view.  Since the model is shared between platforms, we need to define an
 // interface that all view implementations will share.
 
@@ skipping 80 matching lines @@
                            const base::string16& display_text,
                            bool update_popup);
 
   // Sets the window text and the caret position. |notify_text_changed| is true
   // if the model should be notified of the change.
   virtual void SetWindowTextAndCaretPos(const base::string16& text,
                                         size_t caret_pos,
                                         bool update_popup,
                                         bool notify_text_changed) = 0;
 
-  // Sets the edit to forced query mode.  Practically speaking, this means that
-  // if the edit is not in forced query mode, its text is set to "?" with the
-  // cursor at the end, and if the edit is in forced query mode (its first
-  // non-whitespace character is '?'), the text after the '?' is selected.
-  //
-  // In the future we should display the search engine UI for the default engine
-  // rather than '?'.
+  // Transitions the user into keyword mode with their default search provider,
+  // preserving the user's text if they already typed in a query.  Selects the
+  // user's text if they're already in keyword mode.

[Peter Kasting, 2016/04/13 02:52:16]

Doesn't this select the text regardless?  (Which is what it should do, I think.)

[Tom (Use chromium acct), 2016/04/13 23:37:41]

Done.

   virtual void SetForcedQuery() = 0;

[Peter Kasting, 2016/04/13 02:52:16]

Nit: This function name should be changed as "forced query" isn't a meaningful
concept anymore; maybe this should also be named
EnterKeywordModeForDefaultSearchProvider()?

[Tom (Use chromium acct), 2016/04/13 23:37:41]

I Agree. Done.

 
   // Returns true if all text is selected or there is no text at all.
   virtual bool IsSelectAll() const = 0;
 
   // Returns true if the user deleted the suggested text.
   virtual bool DeleteAtEndPressed() = 0;
 
   // Fills |start| and |end| with the indexes of the current selection's bounds.
   // It is not guaranteed that |*start < *end|, as the selection can be
   // directed.  If there is no selection, |start| and |end| will both be equal
@@ skipping 145 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, ShowURL);
 
   // |model_| can be NULL in tests.
   scoped_ptr<OmniboxEditModel> model_;
   OmniboxEditController* controller_;
 
   DISALLOW_COPY_AND_ASSIGN(OmniboxView);
 };
 
 #endif  // COMPONENTS_OMNIBOX_BROWSER_OMNIBOX_VIEW_H_