Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 1855373002: Added comments about expected error messages. (Closed)

Created:
4 years, 8 months ago by bcwhite
Modified:
4 years, 8 months ago
Reviewers:
Will Harris
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added comments about expected error messages. BUG=598191 TBR=asvitkine Committed: https://crrev.com/07bf1e011a454f5eabc8ae5745c4b9267be377f8 Cr-Commit-Position: refs/heads/master@{#384987}

Patch Set 1 #

Messages

Total messages: 10 (5 generated)
bcwhite
4 years, 8 months ago (2016-04-04 19:06:41 UTC) #2
Will Harris
lgtm thanks!
4 years, 8 months ago (2016-04-04 19:09:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1855373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1855373002/1
4 years, 8 months ago (2016-04-04 19:13:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 19:57:30 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 19:58:29 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07bf1e011a454f5eabc8ae5745c4b9267be377f8
Cr-Commit-Position: refs/heads/master@{#384987}

Powered by Google App Engine
This is Rietveld 408576698