Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 185533014: Remove Script::SetData and the script_data parameter from Script::(Compile|New). (Closed)

Created:
6 years, 9 months ago by marja
Modified:
6 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove Script::SetData and the script_data parameter from Script::(Compile|New). This feature makes it possible to associate data with a script and get it back when the script is compiled or when an event is handled. It was historically used by Chromium Dev Tools, but not any more. It is not used by node.js. Note: this has nothing to do with the preparse data, despite the confusing name. The preparse data is passed as ScriptData*. Note 2: This is the same as r19616 ( https://codereview.chromium.org/184403002/ ) with a unused variable fix in bootstrapper.cc. R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19702

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -184 lines) Patch
M include/v8.h View 1 4 chunks +3 lines, -22 lines 0 comments Download
M src/accessors.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/accessors.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/api.cc View 6 chunks +5 lines, -40 lines 0 comments Download
M src/bootstrapper.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M src/compiler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/debug.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/liveedit.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.h View 1 2 chunks +1 line, -5 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-printer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-debug.cc View 9 chunks +3 lines, -67 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
marja
svenpanne, ptal (this is for relanding)
6 years, 9 months ago (2014-03-04 12:43:55 UTC) #1
Sven Panne
LGTM (rubberstamped)
6 years, 9 months ago (2014-03-04 12:58:04 UTC) #2
marja
6 years, 9 months ago (2014-03-07 08:44:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r19702 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698