Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 185533012: Auto generate MediaFeatureNames, its macros and MediaTypeNames (Closed)

Created:
6 years, 9 months ago by Yoav Weiss
Modified:
6 years, 9 months ago
CC:
blink-reviews, kenneth.christiansen, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Auto generate MediaFeatureNames, its macros and MediaTypeNames As part of the review of https://codereview.chromium.org/171383002/ it was requested that the required static strings for the media features and types will be generated as part of the build system. This CL implements that request. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168465

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed comment from RuntimeEnabled #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -140 lines) Patch
A Source/build/scripts/make_media_feature_names.py View 1 chunk +19 lines, -0 lines 0 comments Download
A Source/build/scripts/make_media_features.py View 1 1 chunk +46 lines, -0 lines 0 comments Download
A Source/build/scripts/media_feature_symbol.py View 1 chunk +28 lines, -0 lines 0 comments Download
A Source/build/scripts/templates/MediaFeatures.h.tmpl View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/Init.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/core.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/core_generated.gyp View 1 chunk +74 lines, -0 lines 0 comments Download
D Source/core/css/MediaFeatureNames.h View 1 chunk +0 lines, -86 lines 0 comments Download
D Source/core/css/MediaFeatureNames.cpp View 1 chunk +0 lines, -47 lines 0 comments Download
A Source/core/css/MediaFeatureNames.in View 1 chunk +45 lines, -0 lines 0 comments Download
M Source/core/css/MediaList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/MediaQueryEvaluator.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/css/MediaQueryExp.h View 1 chunk +1 line, -1 line 0 comments Download
A Source/core/css/MediaTypeNames.in View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Yoav Weiss
As discussed on https://codereview.chromium.org/171383002/ , I'm breaking off the .in files part to this CL
6 years, 9 months ago (2014-03-04 10:19:47 UTC) #1
kenneth.r.christiansen
https://codereview.chromium.org/185533012/diff/1/Source/build/scripts/make_media_features.py File Source/build/scripts/make_media_features.py (right): https://codereview.chromium.org/185533012/diff/1/Source/build/scripts/make_media_features.py#newcode17 Source/build/scripts/make_media_features.py:17: 'RuntimeEnabled': None, # What should we do for runtime-enabled ...
6 years, 9 months ago (2014-03-04 12:09:01 UTC) #2
Yoav Weiss
On 2014/03/04 12:09:01, kenneth.r.christiansen wrote: > https://codereview.chromium.org/185533012/diff/1/Source/build/scripts/make_media_features.py > File Source/build/scripts/make_media_features.py (right): > > https://codereview.chromium.org/185533012/diff/1/Source/build/scripts/make_media_features.py#newcode17 > ...
6 years, 9 months ago (2014-03-04 12:36:08 UTC) #3
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-04 18:51:38 UTC) #4
Yoav Weiss
The CQ bit was checked by yoav@yoav.ws
6 years, 9 months ago (2014-03-04 19:46:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/185533012/20001
6 years, 9 months ago (2014-03-04 19:46:37 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 11:16:28 UTC) #7
Message was sent while issue was closed.
Change committed as 168465

Powered by Google App Engine
This is Rietveld 408576698