Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18553004: Add more instructions to text-based spec. (Closed)

Created:
7 years, 5 months ago by Vlad Shcherbina
Modified:
7 years, 5 months ago
Reviewers:
khim, halyavin
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Add more instructions to text-based spec. Along the way, partition and clean up few related tests. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3453 BUG= https://code.google.com/p/nativeclient/issues/detail?id=3487 TEST= this, on bots TEST= ./scons dfacheckvalidator R=halyavin@google.com Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=11669

Patch Set 1 #

Patch Set 2 : cmp fix #

Total comments: 3

Patch Set 3 : lzcnt #

Patch Set 4 : cmp+bt #

Patch Set 5 : bt* #

Patch Set 6 : only allow bt* with immediate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -20 lines) Patch
M src/trusted/validator_ragel/instruction_definitions/general_purpose_instructions.def View 1 chunk +0 lines, -3 lines 0 comments Download
M src/trusted/validator_ragel/spec.py View 1 2 3 4 5 4 chunks +54 lines, -1 line 0 comments Download
M src/trusted/validator_ragel/testdata/32/lzcnt.test View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M src/trusted/validator_ragel/testdata/32/tzcnt.test View 1 chunk +2 lines, -0 lines 0 comments Download
M src/trusted/validator_ragel/testdata/64/bsf-mask.test View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/trusted/validator_ragel/testdata/64/bsr-mask.test View 1 chunk +2 lines, -0 lines 0 comments Download
M src/trusted/validator_ragel/testdata/64/bswap.test View 1 chunk +22 lines, -8 lines 0 comments Download
M src/trusted/validator_ragel/testdata/64/bt.test View 1 2 3 4 5 7 chunks +49 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Vlad Shcherbina
Please take a look.
7 years, 5 months ago (2013-07-03 09:16:24 UTC) #1
halyavin
https://codereview.chromium.org/18553004/diff/3001/src/trusted/validator_ragel/spec.py File src/trusted/validator_ragel/spec.py (right): https://codereview.chromium.org/18553004/diff/3001/src/trusted/validator_ragel/spec.py#newcode570 src/trusted/validator_ragel/spec.py:570: elif _InstructionNameIn(name, ['cmp']): I think we can combine cmp ...
7 years, 5 months ago (2013-07-03 10:51:14 UTC) #2
Vlad Shcherbina
https://codereview.chromium.org/18553004/diff/3001/src/trusted/validator_ragel/spec.py File src/trusted/validator_ragel/spec.py (right): https://codereview.chromium.org/18553004/diff/3001/src/trusted/validator_ragel/spec.py#newcode570 src/trusted/validator_ragel/spec.py:570: elif _InstructionNameIn(name, ['cmp']): On 2013/07/03 10:51:14, halyavin wrote: > ...
7 years, 5 months ago (2013-07-03 11:31:21 UTC) #3
Vlad Shcherbina
https://codereview.chromium.org/18553004/diff/3001/src/trusted/validator_ragel/spec.py File src/trusted/validator_ragel/spec.py (right): https://codereview.chromium.org/18553004/diff/3001/src/trusted/validator_ragel/spec.py#newcode570 src/trusted/validator_ragel/spec.py:570: elif _InstructionNameIn(name, ['cmp']): On 2013/07/03 10:51:14, halyavin wrote: > ...
7 years, 5 months ago (2013-07-03 12:05:04 UTC) #4
halyavin
lgtm
7 years, 5 months ago (2013-07-03 12:15:39 UTC) #5
Vlad Shcherbina
7 years, 5 months ago (2013-07-03 12:50:58 UTC) #6
Message was sent while issue was closed. 
Committed patchset #6 manually as r11669.

Powered by Google App Engine
This is Rietveld 408576698