content/common/media/peer_connection_tracker_messages.h - Issue 1855193002: Move the call to enable the WebRTC event log from PeerConnectionFactory to PeerConnection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/media/peer_connection_tracker_messages.h

Issue 1855193002: Move the call to enable the WebRTC event log from PeerConnectionFactory to PeerConnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments by ncarter and grunell. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_process_host_impl.h ('K') | « content/common/media/aec_dump_messages.h ('k') | content/content_browser.gypi » ('j') | content/renderer/media/peer_connection_tracker.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/media/peer_connection_tracker_messages.h

diff --git a/content/common/media/peer_connection_tracker_messages.h b/content/common/media/peer_connection_tracker_messages.h

index cd774bea3fc2f93d7e000b144424fcb2c72af1d1..056fcce21ff9004b1364cf9ca30ea39fd3a2d93d 100644

--- a/content/common/media/peer_connection_tracker_messages.h

+++ b/content/common/media/peer_connection_tracker_messages.h

@@ -5,6 +5,7 @@

#include "base/values.h"

#include "content/common/content_export.h"

#include "ipc/ipc_message_macros.h"

+#include "ipc/ipc_platform_file.h"

#undef IPC_MESSAGE_EXPORT

#define IPC_MESSAGE_EXPORT CONTENT_EXPORT

@@ -41,3 +42,7 @@ IPC_MESSAGE_CONTROL5(PeerConnectionTrackerHost_GetUserMedia,

// Messages sent to PeerConnectionTracker.

IPC_MESSAGE_CONTROL0(PeerConnectionTracker_GetAllStats)

IPC_MESSAGE_CONTROL0(PeerConnectionTracker_OnSuspend)

+IPC_MESSAGE_CONTROL2(PeerConnectionTracker_StartEventLog,

+ int /* lid */,

dcheng 2016/05/26 22:05:15 Nit: s/lid/<something more descriptive> (for insta

Ivo-OOO until feb 6 2016/05/30 15:04:15 Good point. I will use peer_connection_local_id he

+ IPC::PlatformFileForTransit /* file */)

+IPC_MESSAGE_CONTROL1(PeerConnectionTracker_StopEventLog, int /* lid */)