Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: content/browser/renderer_host/render_process_host_impl.h

Issue 1855193002: Move the call to enable the WebRTC event log from PeerConnectionFactory to PeerConnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comments by ncarter and grunell. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.h
diff --git a/content/browser/renderer_host/render_process_host_impl.h b/content/browser/renderer_host/render_process_host_impl.h
index f5646797ab5f86e35d90d8b11ec2aecff41548aa..6043419a5403025f71f0acaf1da6c0c4fcdce01c 100644
--- a/content/browser/renderer_host/render_process_host_impl.h
+++ b/content/browser/renderer_host/render_process_host_impl.h
@@ -21,6 +21,7 @@
#include "build/build_config.h"
#include "content/browser/child_process_launcher.h"
#include "content/browser/dom_storage/session_storage_namespace_impl.h"
+#include "content/browser/media/webrtc/webrtc_eventlog_host.h"
#include "content/browser/power_monitor_message_broadcaster.h"
#include "content/common/content_export.h"
#include "content/common/mojo/service_registry_impl.h"
@@ -143,8 +144,6 @@ class CONTENT_EXPORT RenderProcessHostImpl
#if defined(ENABLE_WEBRTC)
void EnableAudioDebugRecordings(const base::FilePath& file) override;
void DisableAudioDebugRecordings() override;
- void EnableEventLogRecordings(const base::FilePath& file) override;
- void DisableEventLogRecordings() override;
void SetWebRtcLogMessageCallback(
base::Callback<void(const std::string&)> callback) override;
void ClearWebRtcLogMessageCallback() override;
@@ -152,6 +151,9 @@ class CONTENT_EXPORT RenderProcessHostImpl
bool incoming,
bool outgoing,
const WebRtcRtpPacketCallback& packet_callback) override;
+
+ bool StartWebRTCEventLog(const base::FilePath& file_path) override;
+ bool StopWebRTCEventLog() override;
ncarter (slow) 2016/05/25 21:28:58 Move these up, to keep them in order with the inte
Ivo-OOO until feb 6 2016/05/30 15:04:15 Done, moved the implementation in the .cc as well.
#endif
void ResumeDeferredNavigation(const GlobalRequestID& request_id) override;
void NotifyTimezoneChange(const std::string& timezone) override;
@@ -341,24 +343,15 @@ class CONTENT_EXPORT RenderProcessHostImpl
#if defined(ENABLE_WEBRTC)
void OnRegisterAecDumpConsumer(int id);
- void OnRegisterEventLogConsumer(int id);
void OnUnregisterAecDumpConsumer(int id);
- void OnUnregisterEventLogConsumer(int id);
void RegisterAecDumpConsumerOnUIThread(int id);
- void RegisterEventLogConsumerOnUIThread(int id);
void UnregisterAecDumpConsumerOnUIThread(int id);
- void UnregisterEventLogConsumerOnUIThread(int id);
void EnableAecDumpForId(const base::FilePath& file, int id);
- void EnableEventLogForId(const base::FilePath& file, int id);
// Sends |file_for_transit| to the render process.
void SendAecDumpFileToRenderer(int id,
IPC::PlatformFileForTransit file_for_transit);
- void SendEventLogFileToRenderer(int id,
- IPC::PlatformFileForTransit file_for_transit);
void SendDisableAecDumpToRenderer();
- void SendDisableEventLogToRenderer();
base::FilePath GetAecDumpFilePathWithExtensions(const base::FilePath& file);
- base::FilePath GetEventLogFilePathWithExtensions(const base::FilePath& file);
#endif
std::unique_ptr<MojoChildConnection> mojo_child_connection_;
@@ -479,6 +472,8 @@ class CONTENT_EXPORT RenderProcessHostImpl
std::vector<int> aec_dump_consumers_;
WebRtcStopRtpDumpCallback stop_rtp_dump_callback_;
+
+ WebRTCEventLogHost webrtc_eventlog_host_;
#endif
int worker_ref_count_;

Powered by Google App Engine
This is Rietveld 408576698