content/browser/renderer_host/render_process_host_impl.h - Issue 1855193002: Move the call to enable the WebRTC event log from PeerConnectionFactory to PeerConnection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_process_host_impl.h

Issue 1855193002: Move the call to enable the WebRTC event log from PeerConnectionFactory to PeerConnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Introduced WebRTCCallbackInterface. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/media/webrtc/webrtc_callback_interface_impl.h ('K') | « content/browser/renderer_host/media/peer_connection_tracker_host.cc ('k') | content/browser/renderer_host/render_process_host_impl.cc » ('j') | content/browser/resources/media/dump_creator.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_process_host_impl.h

diff --git a/content/browser/renderer_host/render_process_host_impl.h b/content/browser/renderer_host/render_process_host_impl.h

index f5646797ab5f86e35d90d8b11ec2aecff41548aa..585b5a6dca163dd4e99a622d18e693dcac56252e 100644

--- a/content/browser/renderer_host/render_process_host_impl.h

+++ b/content/browser/renderer_host/render_process_host_impl.h

@@ -143,8 +143,6 @@ class CONTENT_EXPORT RenderProcessHostImpl

#if defined(ENABLE_WEBRTC)

void EnableAudioDebugRecordings(const base::FilePath& file) override;

void DisableAudioDebugRecordings() override;

- void EnableEventLogRecordings(const base::FilePath& file) override;

- void DisableEventLogRecordings() override;

void SetWebRtcLogMessageCallback(

base::Callback<void(const std::string&)> callback) override;

void ClearWebRtcLogMessageCallback() override;

@@ -341,24 +339,15 @@ class CONTENT_EXPORT RenderProcessHostImpl

#if defined(ENABLE_WEBRTC)

void OnRegisterAecDumpConsumer(int id);

- void OnRegisterEventLogConsumer(int id);

void OnUnregisterAecDumpConsumer(int id);

- void OnUnregisterEventLogConsumer(int id);

void RegisterAecDumpConsumerOnUIThread(int id);

- void RegisterEventLogConsumerOnUIThread(int id);

void UnregisterAecDumpConsumerOnUIThread(int id);

- void UnregisterEventLogConsumerOnUIThread(int id);

void EnableAecDumpForId(const base::FilePath& file, int id);

- void EnableEventLogForId(const base::FilePath& file, int id);

// Sends |file_for_transit| to the render process.

void SendAecDumpFileToRenderer(int id,

IPC::PlatformFileForTransit file_for_transit);

- void SendEventLogFileToRenderer(int id,

- IPC::PlatformFileForTransit file_for_transit);

void SendDisableAecDumpToRenderer();

- void SendDisableEventLogToRenderer();

base::FilePath GetAecDumpFilePathWithExtensions(const base::FilePath& file);

- base::FilePath GetEventLogFilePathWithExtensions(const base::FilePath& file);

#endif

std::unique_ptr<MojoChildConnection> mojo_child_connection_;