Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: content/browser/resources/media/dump_creator.js

Issue 1855193002: Move the call to enable the WebRTC event log from PeerConnectionFactory to PeerConnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Introduced WebRTCCallbackInterface. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/resources/media/dump_creator.js
diff --git a/content/browser/resources/media/dump_creator.js b/content/browser/resources/media/dump_creator.js
index c8f53dfc165c69a2765153145451c6c7c4bad818..7b42d4032c592c83345a9fe5534f2aeae986647c 100644
--- a/content/browser/resources/media/dump_creator.js
+++ b/content/browser/resources/media/dump_creator.js
@@ -62,12 +62,21 @@ var DumpCreator = (function() {
' and RTCP packets are logged. These do not include any audio or' +
' video information, nor any other types of personally identifiable' +
' information (so no IP addresses or URLs). Checking this box will' +
- ' enable the recording for currently ongoing WebRTC calls. When' +
- ' the box is unchecked or this page is closed, all active recordings' +
- ' will be stopped. Recording in multiple tabs or multiple recordings' +
- ' in the same tab is currently not supported. When enabling, a' +
- ' filename for the recording can be selected. If an existing file is' +
- ' selected, it will be overwritten. </p>';
+ ' enable the recording for ongoing WebRTC calls and for future' +
+ ' WebRTC calls. When the box is unchecked or this page is closed,' +
+ ' all ongoing recordings will be stopped and this recording' +
+ ' functionality will be disabled for future WebRTC calls. Recording' +
+ ' in multiple tabs or multiple recordings in the same tab will cause' +
+ ' multiple log files to be created. When enabling, a filename for the' +
+ ' recording can be selected. The entered filename is used as a' +
Henrik Grunell 2016/05/13 09:05:31 Nit: "entered" -> "selected".
Ivo-OOO until feb 6 2016/05/18 16:26:54 Done.
+ ' base, to which the following suffixes will be appended.</p>' +
+ ' <p><div>&lt;base filename&gt;.&lt;render process ID&gt;' +
Henrik Grunell 2016/05/13 09:05:31 Nit: No need for <div></div> since there's only on
Ivo-OOO until feb 6 2016/05/18 16:26:55 Done.
+ '.&lt;recording ID&gt;</div></p>' +
+ '<p class=audio-recordings-info>Event logs from different tabs will' +
Henrik Grunell 2016/05/13 09:05:31 This is not always true; different tabs can share
Ivo-OOO until feb 6 2016/05/18 16:26:55 I did not know that. I think removing this part wo
+ ' have a different render process ID, and recordings from multiple' +
+ ' peerconnections within the same tab will have a different recording' +
Henrik Grunell 2016/05/13 09:05:31 Nit: PeerConnections
Henrik Grunell 2016/05/13 09:05:31 "...will have different recording IDs."
Ivo-OOO until feb 6 2016/05/18 16:26:55 This text is removed now.
+ ' ID. If a file with the same name already exists, it will be' +
+ ' overwritten. </p>';
content.getElementsByTagName('a')[0].addEventListener(
'click', this.onDownloadData_.bind(this));
content.getElementsByTagName('input')[0].addEventListener(

Powered by Google App Engine
This is Rietveld 408576698