Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1855143002: Don't load all bytes of video when generating thumbnails. (Closed)

Created:
4 years, 8 months ago by hirono
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Don't load all bytes of video when generating thumbnails. Previously ImageLoader loaded all bytes of video by using XHR before generating thumbnails. The CL fixes it so that ImageLoader assign entry URL to video tag directly, which avoids from loading all bytes to memory. BUG=597243 TEST=manually Review URL: https://codereview.chromium.org/1842313005 Cr-Commit-Position: refs/heads/master@{#384515} (cherry picked from commit 5d9ebe5481791288b7dd28bc51aa608de3e101a9) Committed: https://chromium.googlesource.com/chromium/src/+/72d9e1dfd3164a33424de724465449924dc6dbf3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M ui/file_manager/image_loader/request.js View 4 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
hirono
4 years, 8 months ago (2016-04-04 03:57:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
72d9e1dfd3164a33424de724465449924dc6dbf3.

Powered by Google App Engine
This is Rietveld 408576698