Don't load all bytes of video when generating thumbnails.

Don't load all bytes of video when generating thumbnails.

Previously ImageLoader loaded all bytes of video by using XHR before
generating thumbnails. The CL fixes it so that ImageLoader assign entry
URL to video tag directly, which avoids from loading all bytes to
memory.

BUG=597243
TEST=manually

Committed: https://crrev.com/5d9ebe5481791288b7dd28bc51aa608de3e101a9
Cr-Commit-Position: refs/heads/master@{#384515}

[hirono, 2016-04-01 02:26:28]

hirono@chromium.org changed reviewers:
+ fukino@chromium.org

[hirono, 2016-04-01 02:26:29]

PTAL, thanks!

[fukino, 2016-04-01 05:57:43]

Great improvement! Thank you!

https://codereview.chromium.org/1842313005/diff/1/ui/file_manager/image_loade...
File ui/file_manager/image_loader/request.js (right):

https://codereview.chromium.org/1842313005/diff/1/ui/file_manager/image_loade...
ui/file_manager/image_loader/request.js:315: fulfill(canvas.toDataURL());
I think we can simply do 'return canvas.toDataURL()' without wrapping it by new
Promise.

[hirono, 2016-04-01 06:49:11]

Thank you!

https://codereview.chromium.org/1842313005/diff/1/ui/file_manager/image_loade...
File ui/file_manager/image_loader/request.js (right):

https://codereview.chromium.org/1842313005/diff/1/ui/file_manager/image_loade...
ui/file_manager/image_loader/request.js:315: fulfill(canvas.toDataURL());
On 2016/04/01 05:57:43, fukino wrote:
> I think we can simply do 'return canvas.toDataURL()' without wrapping it by
new
> Promise.

You are right!

[fukino, 2016-04-01 07:00:49]

lgtm. Thank you!

[hirono, 2016-04-01 07:06:13]

The CQ bit was checked by hirono@chromium.org

[hirono, 2016-04-01 07:06:21]

Thank you!

[commit-bot: I haz the power, 2016-04-01 07:06:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1842313005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1842313005/20001

[commit-bot: I haz the power, 2016-04-01 08:02:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-01 08:04:17]

Description was changed from

==========
Don't load all bytes of video when generating thumbnails.

Previously ImageLoader loaded all bytes of video by using XHR before
generating thumbnails. The CL fixes it so that ImageLoader assign entry
URL to video tag directly, which avoids from loading all bytes to
memory.

BUG=597243
TEST=manually
==========

to

==========
Don't load all bytes of video when generating thumbnails.

Previously ImageLoader loaded all bytes of video by using XHR before
generating thumbnails. The CL fixes it so that ImageLoader assign entry
URL to video tag directly, which avoids from loading all bytes to
memory.

BUG=597243
TEST=manually

Committed: https://crrev.com/5d9ebe5481791288b7dd28bc51aa608de3e101a9
Cr-Commit-Position: refs/heads/master@{#384515}
==========

[commit-bot: I haz the power, 2016-04-01 08:04:19]

Patchset 2 (id:??) landed as
https://crrev.com/5d9ebe5481791288b7dd28bc51aa608de3e101a9
Cr-Commit-Position: refs/heads/master@{#384515}