Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 185503002: check the range of exit codes returned from run-webkit-tests. (Closed)

Created:
6 years, 9 months ago by Dirk Pranke
Modified:
6 years, 9 months ago
Reviewers:
scottmg
CC:
blink-reviews
Visibility:
Public.

Description

check the range of exit codes returned from run-webkit-tests. Normally if run-webkit-tests detects regressions, it returns the number of regressions in the exit code (i.e., if 5 tests fail, the exit code is 5). We also use a few magic values to indicate other errors (like 130 for interrupted, -1/254 for internal error, etc.). This means that if we get a lot of errors, we can overlap and produce confusing results. This change adds a range check on the number of errors; if we get more than 101 failures, we limit the exit code to 101. This should prevent overlap while preserving behavior in all but very abnormal circumstances. Arguably a better change would just be to use 1 for the error and ignore the number of failures altogether, but that might break scripts so I'm not going to do this now. TBR=scottmg@chromium.org BUG=309197 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168251

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
Tools/Scripts/webkitpy/layout_tests/controllers/manager.py View 1 chunk +5 lines, -0 lines 0 comments Download
Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dirk Pranke
Committed patchset #1 manually as r168251 (presubmit successful).
6 years, 9 months ago (2014-03-02 00:51:34 UTC) #1
scottmg
6 years, 9 months ago (2014-03-02 02:41:48 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698