Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2124)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

Issue 185503002: check the range of exit codes returned from run-webkit-tests. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py b/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
index 5e65c14a219993a12d2328031465e033bee8c063..30fbad2eb8e8231652d77b65caffad59092a3edf 100644
--- a/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
+++ b/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
@@ -250,6 +250,11 @@ class Manager(object):
summarized_failing_results = test_run_results.summarize_results(self._port, self._expectations, initial_results, retry_results, enabled_pixel_tests_in_retry, only_include_failing=True)
exit_code = summarized_failing_results['num_regressions']
+ if exit_code > test_run_results.MAX_FAILURES_EXIT_STATUS:
+ _log.warning('num regressions (%d) exceeds max exit status (%d)' %
+ (exit_code, test_run_results.MAX_FAILURES_EXIT_STATUS))
+ exit_code = test_run_results.MAX_FAILURES_EXIT_STATUS
+
if not self._options.dry_run:
self._write_json_files(summarized_full_results, summarized_failing_results, initial_results)
self._upload_json_files()
« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698