Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: chromecast/browser/media/cast_mojo_media_application.cc

Issue 1854893002: [chromecast] Bind and run mojo media services on cma thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleaned up deps Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/media/cast_mojo_media_application.cc
diff --git a/chromecast/browser/media/cast_mojo_media_application.cc b/chromecast/browser/media/cast_mojo_media_application.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b21eeba786e1c38312a209d9d95606894b551508
--- /dev/null
+++ b/chromecast/browser/media/cast_mojo_media_application.cc
@@ -0,0 +1,55 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chromecast/browser/media/cast_mojo_media_application.h"
+
+#include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "chromecast/browser/media/cast_mojo_media_client.h"
+#include "media/base/media_log.h"
+#include "media/mojo/services/service_factory_impl.h"
+#include "mojo/shell/public/cpp/connection.h"
+
+namespace chromecast {
+namespace media {
+
+CastMojoMediaApplication::CastMojoMediaApplication(
+ scoped_ptr<CastMojoMediaClient> mojo_media_client,
+ scoped_refptr<base::SingleThreadTaskRunner> media_task_runner)
+ : mojo_media_client_(std::move(mojo_media_client)),
+ media_task_runner_(media_task_runner),
+ media_log_(new ::media::MediaLog()) {
+ DCHECK(mojo_media_client_);
+ DCHECK(media_task_runner_);
+}
+
+CastMojoMediaApplication::~CastMojoMediaApplication() {}
+
+void CastMojoMediaApplication::Initialize(mojo::Connector* connector,
+ const mojo::Identity& identity,
+ uint32_t /* id */) {}
+
+bool CastMojoMediaApplication::AcceptConnection(mojo::Connection* connection) {
+ connection->AddInterface<::media::interfaces::ServiceFactory>(this);
+ return true;
+}
+
+void CastMojoMediaApplication::Create(
+ mojo::Connection* connection,
+ mojo::InterfaceRequest<::media::interfaces::ServiceFactory> request) {
+ if (media_task_runner_->BelongsToCurrentThread()) {
+ // The created object is owned by the pipe.
+ new ::media::ServiceFactoryImpl(
+ std::move(request), connection->GetRemoteInterfaces(), media_log_,
+ ref_factory_.CreateRef(), mojo_media_client_.get());
+ } else {
+ media_task_runner_->PostTask(
+ FROM_HERE,
+ base::Bind(&CastMojoMediaApplication::Create, base::Unretained(this),
halliwell 2016/04/05 00:01:56 I'm not familiar with the lifetime of 'this' - is
alokp 2016/04/05 05:27:16 It wasn't. In fact there was another bug that woul
+ connection, base::Passed(&request)));
+ }
+}
+
+} // namespace media
+} // namespace chromecast

Powered by Google App Engine
This is Rietveld 408576698