[chromecast] Bind and run mojo media services on cma thread.

chromecast/browser/media/cast_mojo_media_application.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chromecast/browser/media/cast_mojo_media_application.h"
+
+#include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "chromecast/browser/media/cast_mojo_media_client.h"
+#include "media/base/media_log.h"
+#include "media/mojo/services/service_factory_impl.h"
+#include "mojo/shell/public/cpp/connection.h"
+
+namespace chromecast {
+namespace media {
+
+CastMojoMediaApplication::CastMojoMediaApplication(
+    scoped_ptr<CastMojoMediaClient> mojo_media_client,
+    scoped_refptr<base::SingleThreadTaskRunner> media_task_runner)
+    : mojo_media_client_(std::move(mojo_media_client)),
+      media_task_runner_(media_task_runner),
+      media_log_(new ::media::MediaLog()) {
+  DCHECK(mojo_media_client_);
+  DCHECK(media_task_runner_);
+}
+
+CastMojoMediaApplication::~CastMojoMediaApplication() {}
+
+void CastMojoMediaApplication::Initialize(mojo::Connector* connector,
+                                          const mojo::Identity& identity,
+                                          uint32_t /* id */) {}
+
+bool CastMojoMediaApplication::AcceptConnection(mojo::Connection* connection) {
+  connection->AddInterface<::media::interfaces::ServiceFactory>(this);
+  return true;
+}
+
+void CastMojoMediaApplication::Create(
+    mojo::Connection* connection,
+    mojo::InterfaceRequest<::media::interfaces::ServiceFactory> request) {
+  if (media_task_runner_->BelongsToCurrentThread()) {
+    // The created object is owned by the pipe.
+    new ::media::ServiceFactoryImpl(
+        std::move(request), connection->GetRemoteInterfaces(), media_log_,
+        ref_factory_.CreateRef(), mojo_media_client_.get());
+  } else {
+    media_task_runner_->PostTask(
+        FROM_HERE,
+        base::Bind(&CastMojoMediaApplication::Create, base::Unretained(this),

[halliwell, 2016/04/05 00:01:56]

I'm not familiar with the lifetime of 'this' - is Unretained definitely safe
here?

[alokp, 2016/04/05 05:27:16]

It wasn't. In fact there was another bug that would cause ref_factory_ to make
media message loop to quit. I have fixed it in the latest patch and added
comments.

+                   connection, base::Passed(&request)));
+  }
+}
+
+}  // namespace media
+}  // namespace chromecast