Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: media/mojo/services/mojo_media_application.cc

Issue 1854893002: [chromecast] Bind and run mojo media services on cma thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move task runner Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/mojo/services/default_mojo_media_client.cc ('k') | media/mojo/services/mojo_media_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/services/mojo_media_application.cc
diff --git a/media/mojo/services/mojo_media_application.cc b/media/mojo/services/mojo_media_application.cc
index 8925e9985eb7658b227bea0def5df91504c46dbd..705c58e7d2cdcc46540ed58d132f0f184806cfbb 100644
--- a/media/mojo/services/mojo_media_application.cc
+++ b/media/mojo/services/mojo_media_application.cc
@@ -6,6 +6,7 @@
#include <utility>
+#include "base/bind_helpers.h"
#include "media/base/media_log.h"
#include "media/mojo/services/mojo_media_client.h"
#include "media/mojo/services/service_factory_impl.h"
@@ -40,10 +41,19 @@ bool MojoMediaApplication::AcceptConnection(mojo::Connection* connection) {
void MojoMediaApplication::Create(
mojo::Connection* connection,
mojo::InterfaceRequest<interfaces::ServiceFactory> request) {
- // The created object is owned by the pipe.
- new ServiceFactoryImpl(std::move(request), connection->GetRemoteInterfaces(),
- media_log_, ref_factory_.CreateRef(),
- mojo_media_client_.get());
+ base::SingleThreadTaskRunner* media_task_runner =
+ mojo_media_client_->media_task_runner();
+ if (!media_task_runner || media_task_runner->BelongsToCurrentThread()) {
+ // The created object is owned by the pipe.
+ new ServiceFactoryImpl(std::move(request),
+ connection->GetRemoteInterfaces(), media_log_,
+ ref_factory_.CreateRef(), mojo_media_client_.get());
+ } else {
+ media_task_runner->PostTask(
+ FROM_HERE,
+ base::Bind(&MojoMediaApplication::Create, base::Unretained(this),
+ connection, base::Passed(&request)));
xhwang 2016/04/01 20:10:05 As far as I understand, a new thread will be creat
alokp 2016/04/01 20:44:48 That would work for our use case. In fact it will
+ }
}
} // namespace media
« no previous file with comments | « media/mojo/services/default_mojo_media_client.cc ('k') | media/mojo/services/mojo_media_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698