Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2014 The Chromium Authors. All rights reserved. | 1 // Copyright 2014 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "media/mojo/services/mojo_media_application.h" | 5 #include "media/mojo/services/mojo_media_application.h" |
| 6 | 6 |
| 7 #include <utility> | 7 #include <utility> |
| 8 | 8 |
| 9 #include "base/bind_helpers.h" | |
| 9 #include "media/base/media_log.h" | 10 #include "media/base/media_log.h" |
| 10 #include "media/mojo/services/mojo_media_client.h" | 11 #include "media/mojo/services/mojo_media_client.h" |
| 11 #include "media/mojo/services/service_factory_impl.h" | 12 #include "media/mojo/services/service_factory_impl.h" |
| 12 #include "mojo/shell/public/cpp/connection.h" | 13 #include "mojo/shell/public/cpp/connection.h" |
| 13 #include "mojo/shell/public/cpp/connector.h" | 14 #include "mojo/shell/public/cpp/connector.h" |
| 14 | 15 |
| 15 namespace media { | 16 namespace media { |
| 16 | 17 |
| 17 // TODO(xhwang): Hook up MediaLog when possible. | 18 // TODO(xhwang): Hook up MediaLog when possible. |
| 18 MojoMediaApplication::MojoMediaApplication( | 19 MojoMediaApplication::MojoMediaApplication( |
| (...skipping 14 matching lines...) Expand all Loading... | |
| 33 } | 34 } |
| 34 | 35 |
| 35 bool MojoMediaApplication::AcceptConnection(mojo::Connection* connection) { | 36 bool MojoMediaApplication::AcceptConnection(mojo::Connection* connection) { |
| 36 connection->AddInterface<interfaces::ServiceFactory>(this); | 37 connection->AddInterface<interfaces::ServiceFactory>(this); |
| 37 return true; | 38 return true; |
| 38 } | 39 } |
| 39 | 40 |
| 40 void MojoMediaApplication::Create( | 41 void MojoMediaApplication::Create( |
| 41 mojo::Connection* connection, | 42 mojo::Connection* connection, |
| 42 mojo::InterfaceRequest<interfaces::ServiceFactory> request) { | 43 mojo::InterfaceRequest<interfaces::ServiceFactory> request) { |
| 43 // The created object is owned by the pipe. | 44 base::SingleThreadTaskRunner* media_task_runner = |
| 44 new ServiceFactoryImpl(std::move(request), connection->GetRemoteInterfaces(), | 45 mojo_media_client_->media_task_runner(); |
| 45 media_log_, ref_factory_.CreateRef(), | 46 if (!media_task_runner || media_task_runner->BelongsToCurrentThread()) { |
| 46 mojo_media_client_.get()); | 47 // The created object is owned by the pipe. |
| 48 new ServiceFactoryImpl(std::move(request), | |
| 49 connection->GetRemoteInterfaces(), media_log_, | |
| 50 ref_factory_.CreateRef(), mojo_media_client_.get()); | |
| 51 } else { | |
| 52 media_task_runner->PostTask( | |
| 53 FROM_HERE, | |
| 54 base::Bind(&MojoMediaApplication::Create, base::Unretained(this), | |
| 55 connection, base::Passed(&request))); | |
|
xhwang
2016/04/01 20:10:05
As far as I understand, a new thread will be creat
alokp
2016/04/01 20:44:48
That would work for our use case. In fact it will
| |
| 56 } | |
| 47 } | 57 } |
| 48 | 58 |
| 49 } // namespace media | 59 } // namespace media |
| OLD | NEW |