pkg/analysis_server/lib/src/status/get_handler.dart - Issue 1854863002: Issue 26096. Explicitly compute the result that ensures that directives are resolved in units.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/status/get_handler.dart

Issue 1854863002: Issue 26096. Explicitly compute the result that ensures that directives are resolved in units. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart ('k') | pkg/analyzer/lib/src/context/context.dart » ('j') | pkg/analyzer/test/src/context/context_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/status/get_handler.dart

diff --git a/pkg/analysis_server/lib/src/status/get_handler.dart b/pkg/analysis_server/lib/src/status/get_handler.dart

index 19ded49597941b664f443edf9b62707a24cb9930..3f88bd9b904523300bec52bbfc1184ad8efb6cfc 100644

--- a/pkg/analysis_server/lib/src/status/get_handler.dart

+++ b/pkg/analysis_server/lib/src/status/get_handler.dart

@@ -457,6 +457,10 @@ class GetHandler {

if (unit != null) {

return unit;

}

+ unit = entry.getValue(RESOLVED_UNIT12);

+ if (unit != null) {

+ return unit;

+ }

return entry.getValue(RESOLVED_UNIT);

}

@@ -526,6 +530,7 @@ class GetHandler {

results.add(RESOLVED_UNIT9);

results.add(RESOLVED_UNIT10);

results.add(RESOLVED_UNIT11);

+ results.add(RESOLVED_UNIT12);

results.add(RESOLVED_UNIT);

results.add(STRONG_MODE_ERRORS);

results.add(USED_IMPORTED_ELEMENTS);