Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: pkg/analyzer/test/src/context/context_test.dart

Issue 1854863002: Issue 26096. Explicitly compute the result that ensures that directives are resolved in units. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/src/context/context_test.dart
diff --git a/pkg/analyzer/test/src/context/context_test.dart b/pkg/analyzer/test/src/context/context_test.dart
index b2e1f0493d69518eaa94363a97cbbbadfc6ecb5e..daa9502f75ce75b937893461963c4de210cad959 100644
--- a/pkg/analyzer/test/src/context/context_test.dart
+++ b/pkg/analyzer/test/src/context/context_test.dart
@@ -1931,14 +1931,14 @@ library expectedToFindSemicolon
LibrarySpecificUnit unitA = new LibrarySpecificUnit(sourceA, sourceA);
for (int i = 0; i < 10000; i++) {
context.performAnalysisTask();
- if (context.getResult(unitA, RESOLVED_UNIT2) != null) {
+ if (context.getResult(unitA, RESOLVED_UNIT3) != null) {
break;
}
}
// Update the source.
// This should invalidate all the results and also reset the driver.
context.setContents(sourceA, "library semicolonWasAdded;");
- expect(context.getResult(unitA, RESOLVED_UNIT2), isNull);
+ expect(context.getResult(unitA, RESOLVED_UNIT3), isNull);
expect(analysisDriver.currentWorkOrder, isNull);
// Continue analysis.
_analyzeAll_assertFinished();
@@ -2120,7 +2120,6 @@ class ClassTwo {
CacheEntry entry =
context.analysisCache.get(new LibrarySpecificUnit(source, source));
entry.setState(RESOLVED_UNIT1, CacheState.FLUSHED);
- entry.setState(RESOLVED_UNIT2, CacheState.FLUSHED);
Paul Berry 2016/04/01 19:13:03 Was this line deleted by mistake? It seems like f
scheglov 2016/04/01 19:49:15 Acknowledged.
entry.setState(RESOLVED_UNIT3, CacheState.FLUSHED);
entry.setState(RESOLVED_UNIT4, CacheState.FLUSHED);
entry.setState(RESOLVED_UNIT5, CacheState.FLUSHED);
@@ -2130,6 +2129,7 @@ class ClassTwo {
entry.setState(RESOLVED_UNIT9, CacheState.FLUSHED);
entry.setState(RESOLVED_UNIT10, CacheState.FLUSHED);
entry.setState(RESOLVED_UNIT11, CacheState.FLUSHED);
+ entry.setState(RESOLVED_UNIT12, CacheState.FLUSHED);
entry.setState(RESOLVED_UNIT, CacheState.FLUSHED);
context.resolveCompilationUnit2(source, source);
« no previous file with comments | « pkg/analyzer/test/generated/incremental_resolver_test.dart ('k') | pkg/analyzer/test/src/task/dart_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698