pkg/analysis_server/lib/src/services/completion/dart/common_usage_sorter.dart - Issue 1854863002: Issue 26096. Explicitly compute the result that ensures that directives are resolved in units.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/common_usage_sorter.dart

Issue 1854863002: Issue 26096. Explicitly compute the result that ensures that directives are resolved in units. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/analysis_server.dart ('k') | pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart » ('j') | pkg/analyzer/test/src/context/context_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart/common_usage_sorter.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/common_usage_sorter.dart b/pkg/analysis_server/lib/src/services/completion/dart/common_usage_sorter.dart

index f06cc0722e52f7a521ed528719b91edc3f76373e..8f27b86a3afdf88ceaccfba7ee0e378816793beb 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/common_usage_sorter.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/common_usage_sorter.dart

@@ -55,7 +55,7 @@ class CommonUsageSorter implements DartContributionSorter {

if (libElem is LibraryElement) {

var unit = request.context.getResult(

new LibrarySpecificUnit(libElem.source, request.source),

- RESOLVED_UNIT3);

+ RESOLVED_UNIT4);

if (unit is CompilationUnit) {

return new CompletionTarget.forOffset(unit, request.offset);

}