Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1854853002: Iteration helper for SVGTextLayoutAttributesBuilder::fillCharacterDataMap (Closed)

Created:
4 years, 8 months ago by fs
Modified:
4 years, 8 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Iteration helper for SVGTextLayoutAttributesBuilder::fillCharacterDataMap Add helper AttributeListsIterator that keeps the iteration state for the x, y, dx, dy and rotate attribute lists. Committed: https://crrev.com/b55bb5a18d56af2305068b414c2351720788ace2 Cr-Commit-Position: refs/heads/master@{#385124}

Patch Set 1 #

Patch Set 2 : ! #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -42 lines) Patch
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp View 1 1 chunk +80 lines, -42 lines 2 comments Download

Dependent Patchsets:

Issue 1849353002 Patch 40001

Messages

Total messages: 8 (3 generated)
fs
To swiftly be followed by https://codereview.chromium.org/1849353002
4 years, 8 months ago (2016-04-04 10:24:29 UTC) #2
pdr.
LGTM https://codereview.chromium.org/1854853002/diff/20001/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp File third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp (right): https://codereview.chromium.org/1854853002/diff/20001/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp#newcode235 third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp:235: m_lastRotation = data.rotate; Not a fan of this, ...
4 years, 8 months ago (2016-04-04 22:12:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854853002/20001
4 years, 8 months ago (2016-04-05 07:45:25 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-05 07:50:29 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 07:51:24 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b55bb5a18d56af2305068b414c2351720788ace2
Cr-Commit-Position: refs/heads/master@{#385124}

Powered by Google App Engine
This is Rietveld 408576698