Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issue 1849353002: Fold 'rotate' attribute semantics into the attribute list iterator (Closed)

Created:
4 years, 8 months ago by fs
Modified:
4 years, 8 months ago
Reviewers:
pdr.
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fold 'rotate' attribute semantics into the attribute list iterator With a small increase in complexity in the updateCharacterData() method in the AttributeListsIterator helper, the loop handling the 'rotate' "tail" semantics can be folded into the loop updating all attributes. Committed: https://crrev.com/d934544befc4375078bc94e24234a98c60c55b1a Cr-Commit-Position: refs/heads/master@{#385128}

Patch Set 1 #

Patch Set 2 : Make dependent. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -20 lines) Patch
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp View 1 2 5 chunks +6 lines, -20 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
fs
4 years, 8 months ago (2016-04-04 10:24:41 UTC) #2
pdr.
On 2016/04/04 at 10:24:41, fs wrote: > LGTM
4 years, 8 months ago (2016-04-04 22:12:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849353002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849353002/40001
4 years, 8 months ago (2016-04-05 08:00:10 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-05 08:05:56 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 08:07:34 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d934544befc4375078bc94e24234a98c60c55b1a
Cr-Commit-Position: refs/heads/master@{#385128}

Powered by Google App Engine
This is Rietveld 408576698