Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Unified Diff: net/socket/socks_client_socket.cc

Issue 1854813004: Add SOCKS4 and SOCKS5 fuzzers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/socks5_client_socket_fuzzer.cc ('k') | net/socket/socks_client_socket_fuzzer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/socks_client_socket.cc
diff --git a/net/socket/socks_client_socket.cc b/net/socket/socks_client_socket.cc
index 0f6e925596e9ef4bae8b8c3db338a4bedc9c6c62..b212f6284c10d1b9674fdcc5a3566320d7f80fa7 100644
--- a/net/socket/socks_client_socket.cc
+++ b/net/socket/socks_client_socket.cc
@@ -417,7 +417,7 @@ int SOCKSClientSocket::DoHandshakeReadComplete(int result) {
reinterpret_cast<const SOCKS4ServerResponse*>(buffer_.data());
if (response->reserved_null != 0x00) {
- LOG(ERROR) << "Unknown response from SOCKS server.";
+ DVLOG(1) << "Unknown response from SOCKS server.";
return ERR_SOCKS_CONNECTION_FAILED;
}
@@ -426,18 +426,18 @@ int SOCKSClientSocket::DoHandshakeReadComplete(int result) {
completed_handshake_ = true;
return OK;
case kServerResponseRejected:
- LOG(ERROR) << "SOCKS request rejected or failed";
+ DVLOG(1) << "SOCKS request rejected or failed";
return ERR_SOCKS_CONNECTION_FAILED;
case kServerResponseNotReachable:
- LOG(ERROR) << "SOCKS request failed because client is not running "
- << "identd (or not reachable from the server)";
+ DVLOG(1) << "SOCKS request failed because client is not running "
+ << "identd (or not reachable from the server)";
return ERR_SOCKS_CONNECTION_HOST_UNREACHABLE;
case kServerResponseMismatchedUserId:
- LOG(ERROR) << "SOCKS request failed because client's identd could "
- << "not confirm the user ID string in the request";
+ DVLOG(1) << "SOCKS request failed because client's identd could "
+ << "not confirm the user ID string in the request";
return ERR_SOCKS_CONNECTION_FAILED;
default:
- LOG(ERROR) << "SOCKS server sent unknown response";
+ DVLOG(1) << "SOCKS server sent unknown response";
return ERR_SOCKS_CONNECTION_FAILED;
}
« no previous file with comments | « net/socket/socks5_client_socket_fuzzer.cc ('k') | net/socket/socks_client_socket_fuzzer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698