Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1854733004: Respect build type arg in build_shaderc.py (Closed)

Created:
4 years, 8 months ago by bsalomon
Modified:
4 years, 8 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/build_shaderc.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
bsalomon
4 years, 8 months ago (2016-04-01 15:22:42 UTC) #3
egdaniel
lgtm
4 years, 8 months ago (2016-04-01 15:23:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854733004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854733004/1
4 years, 8 months ago (2016-04-01 15:24:49 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 15:40:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c770b75c6997bd121e670d3bcd25bc728e0c6635

Powered by Google App Engine
This is Rietveld 408576698