Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: tools/build_shaderc.py

Issue 1854733004: Respect build type arg in build_shaderc.py (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/build_shaderc.py
diff --git a/tools/build_shaderc.py b/tools/build_shaderc.py
index dae0054cfdc9dd8b5f6a669e6394f7ed3baed1df..0cff599bb1ccb705481077973c450ef3df32116b 100644
--- a/tools/build_shaderc.py
+++ b/tools/build_shaderc.py
@@ -63,9 +63,10 @@ def main():
sys.exit('Error creating output dir ' + args.output_dir)
try:
+ build_type_arg='-DCMAKE_BUILD_TYPE=' + args.build_type
subprocess.check_call(['cmake', '-G', generator,
'-DSPIRV_SKIP_EXECUTABLES=ON', '-DSHADERC_ENABLE_SHARED_CRT=ON',
- args.src_dir], cwd=args.output_dir)
+ args.src_dir, build_type_arg], cwd=args.output_dir)
except subprocess.CalledProcessError as error:
sys.exit('Error (ret code: {code}) calling "{cmd}" in {dir}'.format(
code = error.returncode, cmd = error.cmd, dir = args.src_dir))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698