Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: cc/raster/tile_task_worker_pool_unittest.cc

Issue 1854723002: cc: Simplify task and its derived classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/raster/tile_task_worker_pool_unittest.cc
diff --git a/cc/raster/tile_task_worker_pool_unittest.cc b/cc/raster/tile_task_worker_pool_unittest.cc
index 2473629e5f1ce2694443627d0595ff02966fe1b5..3c102182100cfe2777c16447051bbebcc9cfe71a 100644
--- a/cc/raster/tile_task_worker_pool_unittest.cc
+++ b/cc/raster/tile_task_worker_pool_unittest.cc
@@ -51,14 +51,14 @@ enum TileTaskWorkerPoolType {
TILE_TASK_WORKER_POOL_TYPE_BITMAP
};
-class TestRasterTaskImpl : public RasterTask {
+class TestRasterTaskImpl : public DependencyTask {
public:
typedef base::Callback<void(bool was_canceled)> Reply;
TestRasterTaskImpl(const Resource* resource,
const Reply& reply,
- ImageDecodeTask::Vector* dependencies)
- : RasterTask(dependencies),
+ DependencyTask::Vector* dependencies)
+ : DependencyTask(dependencies),
resource_(resource),
reply_(reply),
raster_source_(
@@ -71,13 +71,13 @@ class TestRasterTaskImpl : public RasterTask {
gfx::Rect(1, 1), new_content_id, 1.f, true);
}
- // Overridden from TileTask:
- void ScheduleOnOriginThread(TileTaskClient* client) override {
+ // Overridden from DependencyTask:
+ void ScheduleOnOriginThread(DependencyTaskClient* client) override {
// The raster buffer has no tile ids associated with it for partial update,
// so doesn't need to provide a valid dirty rect.
raster_buffer_ = client->AcquireBufferForRaster(resource_, 0, 0);
}
- void CompleteOnOriginThread(TileTaskClient* client) override {
+ void CompleteOnOriginThread(DependencyTaskClient* client) override {
client->ReleaseBufferForRaster(std::move(raster_buffer_));
reply_.Run(!HasFinishedRunning());
}
@@ -99,7 +99,7 @@ class BlockingTestRasterTaskImpl : public TestRasterTaskImpl {
BlockingTestRasterTaskImpl(const Resource* resource,
const Reply& reply,
base::Lock* lock,
- ImageDecodeTask::Vector* dependencies)
+ DependencyTask::Vector* dependencies)
: TestRasterTaskImpl(resource, reply, dependencies), lock_(lock) {}
// Overridden from Task:
@@ -125,7 +125,7 @@ class TileTaskWorkerPoolTest
bool canceled;
};
- typedef std::vector<scoped_refptr<RasterTask>> RasterTaskVector;
+ typedef std::vector<scoped_refptr<DependencyTask>> RasterTaskVector;
enum NamedTaskSet { REQUIRED_FOR_ACTIVATION, REQUIRED_FOR_DRAW, ALL };
@@ -210,7 +210,7 @@ class TileTaskWorkerPoolTest
RGBA_8888);
const Resource* const_resource = resource.get();
- ImageDecodeTask::Vector empty;
+ DependencyTask::Vector empty;
tasks_.push_back(new TestRasterTaskImpl(
const_resource,
base::Bind(&TileTaskWorkerPoolTest::OnTaskCompleted,
@@ -229,7 +229,7 @@ class TileTaskWorkerPoolTest
RGBA_8888);
const Resource* const_resource = resource.get();
- ImageDecodeTask::Vector empty;
+ DependencyTask::Vector empty;
tasks_.push_back(new BlockingTestRasterTaskImpl(
const_resource,
base::Bind(&TileTaskWorkerPoolTest::OnTaskCompleted,

Powered by Google App Engine
This is Rietveld 408576698