Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: cc/raster/tile_task_worker_pool_perftest.cc

Issue 1854723002: cc: Simplify task and its derived classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/raster/tile_task_worker_pool_perftest.cc
diff --git a/cc/raster/tile_task_worker_pool_perftest.cc b/cc/raster/tile_task_worker_pool_perftest.cc
index 086d7b192dcf06d1239e17e6effeb12c04f52d7a..1a9edf313f3544f99a8c7b13e143acae5f116865 100644
--- a/cc/raster/tile_task_worker_pool_perftest.cc
+++ b/cc/raster/tile_task_worker_pool_perftest.cc
@@ -124,16 +124,16 @@ static const int kTimeLimitMillis = 2000;
static const int kWarmupRuns = 5;
static const int kTimeCheckInterval = 10;
-class PerfImageDecodeTaskImpl : public ImageDecodeTask {
+class PerfImageDecodeTaskImpl : public DependencyTask {
public:
PerfImageDecodeTaskImpl() {}
- // Overridden from Task:
+ // Overridden from DependencyTask:
void RunOnWorkerThread() override {}
-
- // Overridden from TileTask:
- void ScheduleOnOriginThread(TileTaskClient* client) override {}
- void CompleteOnOriginThread(TileTaskClient* client) override { Reset(); }
+ void ScheduleOnOriginThread(DependencyTaskClient* client) override {}
+ void CompleteOnOriginThread(DependencyTaskClient* client) override {
+ Reset();
+ }
void Reset() {
did_run_ = false;
@@ -147,21 +147,19 @@ class PerfImageDecodeTaskImpl : public ImageDecodeTask {
DISALLOW_COPY_AND_ASSIGN(PerfImageDecodeTaskImpl);
};
-class PerfRasterTaskImpl : public RasterTask {
+class PerfRasterTaskImpl : public DependencyTask {
public:
PerfRasterTaskImpl(scoped_ptr<ScopedResource> resource,
- ImageDecodeTask::Vector* dependencies)
- : RasterTask(dependencies), resource_(std::move(resource)) {}
+ DependencyTask::Vector* dependencies)
+ : DependencyTask(dependencies), resource_(std::move(resource)) {}
- // Overridden from Task:
+ // Overridden from DependencyTask:
void RunOnWorkerThread() override {}
-
- // Overridden from TileTask:
- void ScheduleOnOriginThread(TileTaskClient* client) override {
+ void ScheduleOnOriginThread(DependencyTaskClient* client) override {
// No tile ids are given to support partial updates.
raster_buffer_ = client->AcquireBufferForRaster(resource_.get(), 0, 0);
}
- void CompleteOnOriginThread(TileTaskClient* client) override {
+ void CompleteOnOriginThread(DependencyTaskClient* client) override {
client->ReleaseBufferForRaster(std::move(raster_buffer_));
Reset();
}
@@ -183,7 +181,7 @@ class PerfRasterTaskImpl : public RasterTask {
class TileTaskWorkerPoolPerfTestBase {
public:
- typedef std::vector<scoped_refptr<RasterTask>> RasterTaskVector;
+ typedef std::vector<scoped_refptr<DependencyTask>> RasterTaskVector;
enum NamedTaskSet { REQUIRED_FOR_ACTIVATION, REQUIRED_FOR_DRAW, ALL };
@@ -196,13 +194,13 @@ class TileTaskWorkerPoolPerfTestBase {
kTimeCheckInterval) {}
void CreateImageDecodeTasks(unsigned num_image_decode_tasks,
- ImageDecodeTask::Vector* image_decode_tasks) {
+ DependencyTask::Vector* image_decode_tasks) {
for (unsigned i = 0; i < num_image_decode_tasks; ++i)
image_decode_tasks->push_back(new PerfImageDecodeTaskImpl);
}
void CreateRasterTasks(unsigned num_raster_tasks,
- const ImageDecodeTask::Vector& image_decode_tasks,
+ const DependencyTask::Vector& image_decode_tasks,
RasterTaskVector* raster_tasks) {
const gfx::Size size(1, 1);
@@ -212,7 +210,7 @@ class TileTaskWorkerPoolPerfTestBase {
resource->Allocate(size, ResourceProvider::TEXTURE_HINT_IMMUTABLE,
RGBA_8888);
- ImageDecodeTask::Vector dependencies = image_decode_tasks;
+ DependencyTask::Vector dependencies = image_decode_tasks;
raster_tasks->push_back(
new PerfRasterTaskImpl(std::move(resource), &dependencies));
}
@@ -299,7 +297,7 @@ class TileTaskWorkerPoolPerfTest
void RunScheduleTasksTest(const std::string& test_name,
unsigned num_raster_tasks,
unsigned num_image_decode_tasks) {
- ImageDecodeTask::Vector image_decode_tasks;
+ DependencyTask::Vector image_decode_tasks;
RasterTaskVector raster_tasks;
CreateImageDecodeTasks(num_image_decode_tasks, &image_decode_tasks);
CreateRasterTasks(num_raster_tasks, image_decode_tasks, &raster_tasks);
@@ -328,7 +326,7 @@ class TileTaskWorkerPoolPerfTest
unsigned num_raster_tasks,
unsigned num_image_decode_tasks) {
const size_t kNumVersions = 2;
- ImageDecodeTask::Vector image_decode_tasks[kNumVersions];
+ DependencyTask::Vector image_decode_tasks[kNumVersions];
RasterTaskVector raster_tasks[kNumVersions];
for (size_t i = 0; i < kNumVersions; ++i) {
CreateImageDecodeTasks(num_image_decode_tasks, &image_decode_tasks[i]);
@@ -361,7 +359,7 @@ class TileTaskWorkerPoolPerfTest
void RunScheduleAndExecuteTasksTest(const std::string& test_name,
unsigned num_raster_tasks,
unsigned num_image_decode_tasks) {
- ImageDecodeTask::Vector image_decode_tasks;
+ DependencyTask::Vector image_decode_tasks;
RasterTaskVector raster_tasks;
CreateImageDecodeTasks(num_image_decode_tasks, &image_decode_tasks);
CreateRasterTasks(num_raster_tasks, image_decode_tasks, &raster_tasks);
@@ -470,7 +468,7 @@ class TileTaskWorkerPoolCommonPerfTest : public TileTaskWorkerPoolPerfTestBase,
void RunBuildTileTaskGraphTest(const std::string& test_name,
unsigned num_raster_tasks,
unsigned num_image_decode_tasks) {
- ImageDecodeTask::Vector image_decode_tasks;
+ DependencyTask::Vector image_decode_tasks;
RasterTaskVector raster_tasks;
CreateImageDecodeTasks(num_image_decode_tasks, &image_decode_tasks);
CreateRasterTasks(num_raster_tasks, image_decode_tasks, &raster_tasks);

Powered by Google App Engine
This is Rietveld 408576698