Correctly annotate eval origin.

Correctly annotate eval origin.

There were a couple of issues with it:
- interpreter is not supported
- the source position was just accidentally correct for full-codegen
- the eval origin could have been cached

Also fixes a few other places to use AbstractCode.

R=mstarzinger@chromium.org

Committed: https://crrev.com/2f3a171adc9e620c2235bf0562145b9d4eaba66d
Cr-Commit-Position: refs/heads/master@{#35257}

Committed: https://crrev.com/ad4e8a27963b704bb70ec8bac0991c57296b1d16
Cr-Commit-Position: refs/heads/master@{#35481}

Committed: https://crrev.com/89d7bfda0d3d3ed48a174a2851cfe5da0b31f056
Cr-Commit-Position: refs/heads/master@{#35581}

[Yang, 2016-04-01 13:33:49]

Please take a look. I'll port to other platforms later.

[Yang, 2016-04-04 09:46:14]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 09:46:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854713002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854713002/20001

[commit-bot: I haz the power, 2016-04-04 09:53:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 09:53:18]

Dry run: Try jobs failed on following builders:
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)

[Yang, 2016-04-04 10:59:01]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 10:59:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854713002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854713002/40001

[commit-bot: I haz the power, 2016-04-04 11:23:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 11:23:16]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-04-05 09:33:15]

On 2016/04/04 11:23:16, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

ping

[Michael Starzinger, 2016-04-05 09:56:49]

LGTM. I like it. Only nits.

https://codereview.chromium.org/1854713002/diff/40001/src/frames.h
File src/frames.h (right):

https://codereview.chromium.org/1854713002/diff/40001/src/frames.h#newcode903
src/frames.h:903: void PatchBytecodeArray(Object* bytecode_array);
nit: Let's also change the signature of the setter to only allow
"BytecodeArray". If the getter guarantees proper type, then the setter needs to
enforce that guarantee.

https://codereview.chromium.org/1854713002/diff/40001/src/full-codegen/arm/fu...
File src/full-codegen/arm/full-codegen-arm.cc (right):

https://codereview.chromium.org/1854713002/diff/40001/src/full-codegen/arm/fu...
src/full-codegen/arm/full-codegen-arm.cc:2681: // r1: the start position of the
scope the calls resides in.
nit: Comment is outdated. Applies to all architectures.

https://codereview.chromium.org/1854713002/diff/40001/src/full-codegen/ia32/f...
File src/full-codegen/ia32/full-codegen-ia32.cc (right):

https://codereview.chromium.org/1854713002/diff/40001/src/full-codegen/ia32/f...
src/full-codegen/ia32/full-codegen-ia32.cc:2617: // In a call to eval, we first
call Runtime_ResolvePossiblyDirectEval
nit: Nice catch. Would you be willing to port it to all architectures? I'll
offer cookie from the MK as a bounty. :)

[Yang, 2016-04-05 11:01:26]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-04-05 11:01:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1854713002/#ps60001
(title: "address comments")

[Yang, 2016-04-05 11:01:31]

On 2016/04/05 09:56:49, Michael Starzinger wrote:
> LGTM. I like it. Only nits.
> 
> https://codereview.chromium.org/1854713002/diff/40001/src/frames.h
> File src/frames.h (right):
> 
> https://codereview.chromium.org/1854713002/diff/40001/src/frames.h#newcode903
> src/frames.h:903: void PatchBytecodeArray(Object* bytecode_array);
> nit: Let's also change the signature of the setter to only allow
> "BytecodeArray". If the getter guarantees proper type, then the setter needs
to
> enforce that guarantee.
> 
>
https://codereview.chromium.org/1854713002/diff/40001/src/full-codegen/arm/fu...
> File src/full-codegen/arm/full-codegen-arm.cc (right):
> 
>
https://codereview.chromium.org/1854713002/diff/40001/src/full-codegen/arm/fu...
> src/full-codegen/arm/full-codegen-arm.cc:2681: // r1: the start position of
the
> scope the calls resides in.
> nit: Comment is outdated. Applies to all architectures.
> 
>
https://codereview.chromium.org/1854713002/diff/40001/src/full-codegen/ia32/f...
> File src/full-codegen/ia32/full-codegen-ia32.cc (right):
> 
>
https://codereview.chromium.org/1854713002/diff/40001/src/full-codegen/ia32/f...
> src/full-codegen/ia32/full-codegen-ia32.cc:2617: // In a call to eval, we
first
> call Runtime_ResolvePossiblyDirectEval
> nit: Nice catch. Would you be willing to port it to all architectures? I'll
> offer cookie from the MK as a bounty. :)

Always ready to collect some bounty :)

[commit-bot: I haz the power, 2016-04-05 11:01:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854713002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854713002/60001

[commit-bot: I haz the power, 2016-04-05 11:30:28]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-05 11:31:54]

Description was changed from

==========
Correctly annotate eval origin.

There were a couple of issues with it:
- interpreter is not supported
- the source position was just accidentally correct for full-codegen
- the eval origin could have been cached

Also fixes a few other places to use AbstractCode.

R=mstarzinger@chromium.org
==========

to

==========
Correctly annotate eval origin.

There were a couple of issues with it:
- interpreter is not supported
- the source position was just accidentally correct for full-codegen
- the eval origin could have been cached

Also fixes a few other places to use AbstractCode.

R=mstarzinger@chromium.org

Committed: https://crrev.com/2f3a171adc9e620c2235bf0562145b9d4eaba66d
Cr-Commit-Position: refs/heads/master@{#35257}
==========

[commit-bot: I haz the power, 2016-04-05 11:31:55]

Patchset 4 (id:??) landed as
https://crrev.com/2f3a171adc9e620c2235bf0562145b9d4eaba66d
Cr-Commit-Position: refs/heads/master@{#35257}

[Michael Achenbach, 2016-04-05 13:00:26]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1858773004/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Crashes a layout test:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....

[Yang, 2016-04-05 13:02:51]

Description was changed from

==========
Correctly annotate eval origin.

There were a couple of issues with it:
- interpreter is not supported
- the source position was just accidentally correct for full-codegen
- the eval origin could have been cached

Also fixes a few other places to use AbstractCode.

R=mstarzinger@chromium.org

Committed: https://crrev.com/2f3a171adc9e620c2235bf0562145b9d4eaba66d
Cr-Commit-Position: refs/heads/master@{#35257}
==========

to

==========
Correctly annotate eval origin.

There were a couple of issues with it:
- interpreter is not supported
- the source position was just accidentally correct for full-codegen
- the eval origin could have been cached

Also fixes a few other places to use AbstractCode.

R=mstarzinger@chromium.org

Committed: https://crrev.com/2f3a171adc9e620c2235bf0562145b9d4eaba66d
Cr-Commit-Position: refs/heads/master@{#35257}
==========

[Yang, 2016-04-14 09:43:58]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-04-14 09:43:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1854713002/#ps80001
(title: "fix + rebase")

[commit-bot: I haz the power, 2016-04-14 09:44:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854713002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854713002/80001

[commit-bot: I haz the power, 2016-04-14 10:07:55]

Description was changed from

==========
Correctly annotate eval origin.

There were a couple of issues with it:
- interpreter is not supported
- the source position was just accidentally correct for full-codegen
- the eval origin could have been cached

Also fixes a few other places to use AbstractCode.

R=mstarzinger@chromium.org

Committed: https://crrev.com/2f3a171adc9e620c2235bf0562145b9d4eaba66d
Cr-Commit-Position: refs/heads/master@{#35257}
==========

to

==========
Correctly annotate eval origin.

There were a couple of issues with it:
- interpreter is not supported
- the source position was just accidentally correct for full-codegen
- the eval origin could have been cached

Also fixes a few other places to use AbstractCode.

R=mstarzinger@chromium.org

Committed: https://crrev.com/2f3a171adc9e620c2235bf0562145b9d4eaba66d
Cr-Commit-Position: refs/heads/master@{#35257}
==========

[commit-bot: I haz the power, 2016-04-14 10:07:56]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-14 10:08:21]

Description was changed from

==========
Correctly annotate eval origin.

There were a couple of issues with it:
- interpreter is not supported
- the source position was just accidentally correct for full-codegen
- the eval origin could have been cached

Also fixes a few other places to use AbstractCode.

R=mstarzinger@chromium.org

Committed: https://crrev.com/2f3a171adc9e620c2235bf0562145b9d4eaba66d
Cr-Commit-Position: refs/heads/master@{#35257}
==========

to

==========
Correctly annotate eval origin.

There were a couple of issues with it:
- interpreter is not supported
- the source position was just accidentally correct for full-codegen
- the eval origin could have been cached

Also fixes a few other places to use AbstractCode.

R=mstarzinger@chromium.org

Committed: https://crrev.com/2f3a171adc9e620c2235bf0562145b9d4eaba66d
Cr-Commit-Position: refs/heads/master@{#35257}

Committed: https://crrev.com/ad4e8a27963b704bb70ec8bac0991c57296b1d16
Cr-Commit-Position: refs/heads/master@{#35481}
==========

[commit-bot: I haz the power, 2016-04-14 10:08:23]

Patchset 5 (id:??) landed as
https://crrev.com/ad4e8a27963b704bb70ec8bac0991c57296b1d16
Cr-Commit-Position: refs/heads/master@{#35481}

[Yang, 2016-04-14 12:44:42]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1888013002/ by yangguo@chromium.org.

The reason for reverting is: performance impact.

[Yang, 2016-04-14 12:46:00]

Description was changed from

==========
Correctly annotate eval origin.

There were a couple of issues with it:
- interpreter is not supported
- the source position was just accidentally correct for full-codegen
- the eval origin could have been cached

Also fixes a few other places to use AbstractCode.

R=mstarzinger@chromium.org

Committed: https://crrev.com/2f3a171adc9e620c2235bf0562145b9d4eaba66d
Cr-Commit-Position: refs/heads/master@{#35257}

Committed: https://crrev.com/ad4e8a27963b704bb70ec8bac0991c57296b1d16
Cr-Commit-Position: refs/heads/master@{#35481}
==========

to

==========
Correctly annotate eval origin.

There were a couple of issues with it:
- interpreter is not supported
- the source position was just accidentally correct for full-codegen
- the eval origin could have been cached

Also fixes a few other places to use AbstractCode.

R=mstarzinger@chromium.org

Committed: https://crrev.com/2f3a171adc9e620c2235bf0562145b9d4eaba66d
Cr-Commit-Position: refs/heads/master@{#35257}

Committed: https://crrev.com/ad4e8a27963b704bb70ec8bac0991c57296b1d16
Cr-Commit-Position: refs/heads/master@{#35481}
==========

[Yang, 2016-04-14 13:40:39]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-04-14 13:40:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1854713002/#ps100001
(title: "fix performance issues")

[commit-bot: I haz the power, 2016-04-14 13:40:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854713002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854713002/100001

[commit-bot: I haz the power, 2016-04-14 13:54:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 13:54:43]

Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[Yang, 2016-04-15 06:56:27]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-04-15 06:56:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1854713002/#ps140001
(title: "small fixes and golden files")

[commit-bot: I haz the power, 2016-04-15 06:56:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854713002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854713002/140001

[commit-bot: I haz the power, 2016-04-15 07:11:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-15 07:11:27]

Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[Yang, 2016-04-15 07:40:52]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-04-15 07:40:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1854713002/#ps160001
(title: "fix interpreter")

[commit-bot: I haz the power, 2016-04-15 07:40:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854713002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854713002/160001

[commit-bot: I haz the power, 2016-04-15 08:03:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-15 08:03:30]

Try jobs failed on following builders:
  v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_nodcheck_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng_tr...)

[Yang, 2016-04-18 12:56:47]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-04-18 12:56:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1854713002/#ps200001
(title: "rebase")

[commit-bot: I haz the power, 2016-04-18 12:56:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1854713002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1854713002/200001

[commit-bot: I haz the power, 2016-04-18 13:20:49]

Description was changed from

==========
Correctly annotate eval origin.

There were a couple of issues with it:
- interpreter is not supported
- the source position was just accidentally correct for full-codegen
- the eval origin could have been cached

Also fixes a few other places to use AbstractCode.

R=mstarzinger@chromium.org

Committed: https://crrev.com/2f3a171adc9e620c2235bf0562145b9d4eaba66d
Cr-Commit-Position: refs/heads/master@{#35257}

Committed: https://crrev.com/ad4e8a27963b704bb70ec8bac0991c57296b1d16
Cr-Commit-Position: refs/heads/master@{#35481}
==========

to

==========
Correctly annotate eval origin.

There were a couple of issues with it:
- interpreter is not supported
- the source position was just accidentally correct for full-codegen
- the eval origin could have been cached

Also fixes a few other places to use AbstractCode.

R=mstarzinger@chromium.org

Committed: https://crrev.com/2f3a171adc9e620c2235bf0562145b9d4eaba66d
Cr-Commit-Position: refs/heads/master@{#35257}

Committed: https://crrev.com/ad4e8a27963b704bb70ec8bac0991c57296b1d16
Cr-Commit-Position: refs/heads/master@{#35481}
==========

[commit-bot: I haz the power, 2016-04-18 13:20:51]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-04-18 13:21:12]

Description was changed from

==========
Correctly annotate eval origin.

There were a couple of issues with it:
- interpreter is not supported
- the source position was just accidentally correct for full-codegen
- the eval origin could have been cached

Also fixes a few other places to use AbstractCode.

R=mstarzinger@chromium.org

Committed: https://crrev.com/2f3a171adc9e620c2235bf0562145b9d4eaba66d
Cr-Commit-Position: refs/heads/master@{#35257}

Committed: https://crrev.com/ad4e8a27963b704bb70ec8bac0991c57296b1d16
Cr-Commit-Position: refs/heads/master@{#35481}
==========

to

==========
Correctly annotate eval origin.

There were a couple of issues with it:
- interpreter is not supported
- the source position was just accidentally correct for full-codegen
- the eval origin could have been cached

Also fixes a few other places to use AbstractCode.

R=mstarzinger@chromium.org

Committed: https://crrev.com/2f3a171adc9e620c2235bf0562145b9d4eaba66d
Cr-Commit-Position: refs/heads/master@{#35257}

Committed: https://crrev.com/ad4e8a27963b704bb70ec8bac0991c57296b1d16
Cr-Commit-Position: refs/heads/master@{#35481}

Committed: https://crrev.com/89d7bfda0d3d3ed48a174a2851cfe5da0b31f056
Cr-Commit-Position: refs/heads/master@{#35581}
==========

[commit-bot: I haz the power, 2016-04-18 13:21:13]

Patchset 11 (id:??) landed as
https://crrev.com/89d7bfda0d3d3ed48a174a2851cfe5da0b31f056
Cr-Commit-Position: refs/heads/master@{#35581}