Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1854583002: Migrate tsmon protos to proto3 (Closed)

Created:
4 years, 8 months ago by dsansome
Modified:
4 years, 8 months ago
Reviewers:
iannucci
CC:
agable, andrew.wang, chromium-reviews, infra-reviews+luci-go_chromium.org, M-A Ruel, tandrii+luci-go_chromium.org, todd
Base URL:
git@github.com:luci/luci-go.git@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -801 lines) Patch
M appengine/tsmon/global_callback_test.go View 2 chunks +1 line, -2 lines 0 comments Download
M appengine/tsmon/middleware.go View 4 chunks +8 lines, -9 lines 0 comments Download
M appengine/tsmon/middleware_test.go View 2 chunks +1 line, -2 lines 0 comments Download
M appengine/tsmon/standardmetrics_test.go View 2 chunks +1 line, -2 lines 0 comments Download
M common/tsmon/context.go View 2 chunks +1 line, -2 lines 0 comments Download
M common/tsmon/field/field.go View 2 chunks +5 lines, -7 lines 0 comments Download
M common/tsmon/field/field_test.go View 4 chunks +9 lines, -11 lines 0 comments Download
M common/tsmon/flush_test.go View 2 chunks +1 line, -4 lines 0 comments Download
M common/tsmon/metric/metric_test.go View 2 chunks +1 line, -2 lines 0 comments Download
M common/tsmon/monitor/acq.go View 5 chunks +23 lines, -24 lines 0 comments Download
M common/tsmon/monitor/acq_test.go View 14 chunks +57 lines, -58 lines 0 comments Download
M common/tsmon/store/inmemory_test.go View 2 chunks +1 line, -2 lines 0 comments Download
M common/tsmon/store/testing.go View 7 chunks +11 lines, -11 lines 0 comments Download
M common/tsmon/target/target.go View 3 chunks +33 lines, -33 lines 0 comments Download
M common/tsmon/ts_mon_proto/acquisition_network_device.proto View 1 chunk +7 lines, -9 lines 0 comments Download
M common/tsmon/ts_mon_proto/acquisition_network_device.pb.go View 1 chunk +9 lines, -110 lines 0 comments Download
M common/tsmon/ts_mon_proto/acquisition_task.proto View 1 chunk +6 lines, -8 lines 0 comments Download
M common/tsmon/ts_mon_proto/acquisition_task.pb.go View 1 chunk +8 lines, -96 lines 0 comments Download
M common/tsmon/ts_mon_proto/metrics.proto View 4 chunks +33 lines, -32 lines 0 comments Download
M common/tsmon/ts_mon_proto/metrics.pb.go View 8 chunks +55 lines, -376 lines 0 comments Download
M common/tsmon/ts_mon_proto/proto-gen.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
dsansome
4 years, 8 months ago (2016-04-01 04:29:34 UTC) #2
iannucci
lgtm Lgtm, though make sure you have correctly ported the former default values into the ...
4 years, 8 months ago (2016-04-01 05:52:22 UTC) #3
dsansome
On 2016/04/01 05:52:22, iannucci wrote: > lgtm > > Lgtm, though make sure you have ...
4 years, 8 months ago (2016-04-04 03:18:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854583002/1
4 years, 8 months ago (2016-04-04 03:18:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://github.com/luci/luci-go/commit/f9ccd6e92419d931bfe3bd88b2f62ad1e9db2e82
4 years, 8 months ago (2016-04-04 03:21:53 UTC) #8
dsansome
4 years, 8 months ago (2016-04-04 03:59:55 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1857643003/ by dsansome@chromium.org.

The reason for reverting is: On second thoughts this can't possibly work because
the type of metric in a MetricsData message is determined by the presence of
optional fields..

Powered by Google App Engine
This is Rietveld 408576698