Migrate tsmon protos to proto3

common/tsmon/monitor/acq_test.go

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package monitor
 
 import (
         "fmt"
         "math"
         "testing"
         "time"
 
-        "github.com/golang/protobuf/proto"
         "github.com/luci/luci-go/common/tsmon/distribution"
         "github.com/luci/luci-go/common/tsmon/field"
         "github.com/luci/luci-go/common/tsmon/target"
         "github.com/luci/luci-go/common/tsmon/types"
 
         pb "github.com/luci/luci-go/common/tsmon/ts_mon_proto"
         . "github.com/smartystreets/goconvey/convey"
 )
 
 func TestRunningZeroes(t *testing.T) {
@@ skipping 29 matching lines @@
                 })
         }
 }
 
 func TestSerializeDistribution(t *testing.T) {
         Convey("Fixed width params", t, func() {
                 d := distribution.New(distribution.FixedWidthBucketer(10, 20))
                 dpb := serializeDistribution(d)
 
                 So(*dpb, ShouldResemble, pb.PrecomputedDistribution{
-                        SpecType:     pb.PrecomputedDistribution_CUSTOM_PARAMETERIZED.Enum(),
-                        Width:        proto.Float64(10),
-                        GrowthFactor: proto.Float64(0),
-                        NumBuckets:   proto.Int32(20),
+                        SpecType:     pb.PrecomputedDistribution_CUSTOM_PARAMETERIZED,
+                        Width:        10,
+                        GrowthFactor: 0,
+                        NumBuckets:   20,
                 })
         })
 
         Convey("Growth factor 2 params", t, func() {
                 d := distribution.New(distribution.GeometricBucketer(2, 20))
                 dpb := serializeDistribution(d)
 
                 So(*dpb, ShouldResemble, pb.PrecomputedDistribution{
-                        SpecType: pb.PrecomputedDistribution_CANONICAL_POWERS_OF_2.Enum(),
+                        SpecType: pb.PrecomputedDistribution_CANONICAL_POWERS_OF_2,
                 })
         })
 
         Convey("Growth factor 10^0.2 params", t, func() {
                 d := distribution.New(distribution.GeometricBucketer(math.Pow(10, 0.2), 20))
                 dpb := serializeDistribution(d)
 
                 So(*dpb, ShouldResemble, pb.PrecomputedDistribution{
-                        SpecType: pb.PrecomputedDistribution_CANONICAL_POWERS_OF_10_P_0_2.Enum(),
+                        SpecType: pb.PrecomputedDistribution_CANONICAL_POWERS_OF_10_P_0_2,
                 })
         })
 
         Convey("Growth factor 10 params", t, func() {
                 d := distribution.New(distribution.GeometricBucketer(10, 20))
                 dpb := serializeDistribution(d)
 
                 So(*dpb, ShouldResemble, pb.PrecomputedDistribution{
-                        SpecType: pb.PrecomputedDistribution_CANONICAL_POWERS_OF_10.Enum(),
+                        SpecType: pb.PrecomputedDistribution_CANONICAL_POWERS_OF_10,
                 })
         })
 
         Convey("Custom geometric params", t, func() {
                 d := distribution.New(distribution.GeometricBucketer(4, 20))
                 dpb := serializeDistribution(d)
 
                 So(*dpb, ShouldResemble, pb.PrecomputedDistribution{
-                        SpecType:     pb.PrecomputedDistribution_CUSTOM_PARAMETERIZED.Enum(),
-                        Width:        proto.Float64(0),
-                        GrowthFactor: proto.Float64(4),
-                        NumBuckets:   proto.Int32(20),
+                        SpecType:     pb.PrecomputedDistribution_CUSTOM_PARAMETERIZED,
+                        Width:        0,
+                        GrowthFactor: 4,
+                        NumBuckets:   20,
                 })
         })
 
         Convey("Populates buckets", t, func() {
                 d := distribution.New(distribution.FixedWidthBucketer(10, 2))
                 d.Add(0)
                 d.Add(1)
                 d.Add(2)
                 d.Add(20)
 
                 dpb := serializeDistribution(d)
                 So(*dpb, ShouldResemble, pb.PrecomputedDistribution{
-                        SpecType:     pb.PrecomputedDistribution_CUSTOM_PARAMETERIZED.Enum(),
-                        Width:        proto.Float64(10),
-                        GrowthFactor: proto.Float64(0),
-                        NumBuckets:   proto.Int32(2),
+                        SpecType:     pb.PrecomputedDistribution_CUSTOM_PARAMETERIZED,
+                        Width:        10,
+                        GrowthFactor: 0,
+                        NumBuckets:   2,
 
                         Bucket:    []int64{3},
-                        Underflow: proto.Int64(0),
-                        Overflow:  proto.Int64(1),
-                        Mean:      proto.Float64(5.75),
+                        Underflow: 0,
+                        Overflow:  1,
+                        Mean:      5.75,
                 })
         })
 }
 
 func TestSerializeCell(t *testing.T) {
         Convey("Int", t, func() {
                 ret := SerializeCell(types.Cell{
                         types.MetricInfo{
                                 Name:        "foo",
                                 Description: "bar",
                                 Fields:      []field.Field{},
                                 ValueType:   types.NonCumulativeIntType,
                         },
                         types.CellData{
                                 FieldVals: []interface{}{},
                                 Target:    &target.Task{},
                                 ResetTime: time.Date(2000, 1, 2, 3, 4, 5, 6, time.UTC),
                                 Value:     int64(42),
                         },
                 })
                 So(ret, ShouldResemble, &pb.MetricsData{
-                        Name:             proto.String("foo"),
-                        Description:      proto.String("bar"),
-                        MetricNamePrefix: proto.String("/chrome/infra/"),
+                        Name:             "foo",
+                        Description:      "bar",
+                        MetricNamePrefix: "/chrome/infra/",
                         Fields:           []*pb.MetricsField{},
-                        StartTimestampUs: proto.Uint64(946782245000000),
+                        StartTimestampUs: 946782245000000,
                         Task:             &pb.Task{},
-                        Gauge:            proto.Int64(42),
+                        Gauge:            42,
                 })
         })
 
         Convey("Counter", t, func() {
                 ret := SerializeCell(types.Cell{
                         types.MetricInfo{
                                 Name:        "foo",
                                 Description: "bar",
                                 Fields:      []field.Field{},
                                 ValueType:   types.CumulativeIntType,
                         },
                         types.CellData{
                                 FieldVals: []interface{}{},
                                 Target:    &target.Task{},
                                 ResetTime: time.Date(2000, 1, 2, 3, 4, 5, 6, time.UTC),
                                 Value:     int64(42),
                         },
                 })
                 So(ret, ShouldResemble, &pb.MetricsData{
-                        Name:             proto.String("foo"),
-                        Description:      proto.String("bar"),
-                        MetricNamePrefix: proto.String("/chrome/infra/"),
+                        Name:             "foo",
+                        Description:      "bar",
+                        MetricNamePrefix: "/chrome/infra/",
                         Fields:           []*pb.MetricsField{},
-                        StartTimestampUs: proto.Uint64(946782245000000),
+                        StartTimestampUs: 946782245000000,
                         Task:             &pb.Task{},
-                        Counter:          proto.Int64(42),
+                        Counter:          42,
                 })
         })
 
         Convey("Float", t, func() {
                 ret := SerializeCell(types.Cell{
                         types.MetricInfo{
                                 Name:        "foo",
                                 Description: "bar",
                                 Fields:      []field.Field{},
                                 ValueType:   types.NonCumulativeFloatType,
                         },
                         types.CellData{
                                 FieldVals: []interface{}{},
                                 Target:    &target.Task{},
                                 ResetTime: time.Date(2000, 1, 2, 3, 4, 5, 6, time.UTC),
                                 Value:     float64(42),
                         },
                 })
                 So(ret, ShouldResemble, &pb.MetricsData{
-                        Name:             proto.String("foo"),
-                        Description:      proto.String("bar"),
-                        MetricNamePrefix: proto.String("/chrome/infra/"),
+                        Name:             "foo",
+                        Description:      "bar",
+                        MetricNamePrefix: "/chrome/infra/",
                         Fields:           []*pb.MetricsField{},
-                        StartTimestampUs: proto.Uint64(946782245000000),
+                        StartTimestampUs: 946782245000000,
                         Task:             &pb.Task{},
-                        NoncumulativeDoubleValue: proto.Float64(42),
+                        NoncumulativeDoubleValue: 42,
                 })
         })
 
         Convey("FloatCounter", t, func() {
                 ret := SerializeCell(types.Cell{
                         types.MetricInfo{
                                 Name:        "foo",
                                 Description: "bar",
                                 Fields:      []field.Field{},
                                 ValueType:   types.CumulativeFloatType,
                         },
                         types.CellData{
                                 FieldVals: []interface{}{},
                                 Target:    &target.Task{},
                                 ResetTime: time.Date(2000, 1, 2, 3, 4, 5, 6, time.UTC),
                                 Value:     float64(42),
                         },
                 })
                 So(ret, ShouldResemble, &pb.MetricsData{
-                        Name:             proto.String("foo"),
-                        Description:      proto.String("bar"),
-                        MetricNamePrefix: proto.String("/chrome/infra/"),
+                        Name:             "foo",
+                        Description:      "bar",
+                        MetricNamePrefix: "/chrome/infra/",
                         Fields:           []*pb.MetricsField{},
-                        StartTimestampUs: proto.Uint64(946782245000000),
+                        StartTimestampUs: 946782245000000,
                         Task:             &pb.Task{},
-                        CumulativeDoubleValue: proto.Float64(42),
+                        CumulativeDoubleValue: 42,
                 })
         })
 
         Convey("String", t, func() {
                 ret := SerializeCell(types.Cell{
                         types.MetricInfo{
                                 Name:        "foo",
                                 Description: "bar",
                                 Fields:      []field.Field{},
                                 ValueType:   types.StringType,
                         },
                         types.CellData{
                                 FieldVals: []interface{}{},
                                 Target:    &target.Task{},
                                 ResetTime: time.Date(2000, 1, 2, 3, 4, 5, 6, time.UTC),
                                 Value:     "hello",
                         },
                 })
                 So(ret, ShouldResemble, &pb.MetricsData{
-                        Name:             proto.String("foo"),
-                        Description:      proto.String("bar"),
-                        MetricNamePrefix: proto.String("/chrome/infra/"),
+                        Name:             "foo",
+                        Description:      "bar",
+                        MetricNamePrefix: "/chrome/infra/",
                         Fields:           []*pb.MetricsField{},
-                        StartTimestampUs: proto.Uint64(946782245000000),
+                        StartTimestampUs: 946782245000000,
                         Task:             &pb.Task{},
-                        StringValue:      proto.String("hello"),
+                        StringValue:      "hello",
                 })
         })
 
         Convey("Boolean", t, func() {
                 ret := SerializeCell(types.Cell{
                         types.MetricInfo{
                                 Name:        "foo",
                                 Description: "bar",
                                 Fields:      []field.Field{},
                                 ValueType:   types.BoolType,
                         },
                         types.CellData{
                                 FieldVals: []interface{}{},
                                 Target:    &target.Task{},
                                 ResetTime: time.Date(2000, 1, 2, 3, 4, 5, 6, time.UTC),
                                 Value:     true,
                         },
                 })
                 So(ret, ShouldResemble, &pb.MetricsData{
-                        Name:             proto.String("foo"),
-                        Description:      proto.String("bar"),
-                        MetricNamePrefix: proto.String("/chrome/infra/"),
+                        Name:             "foo",
+                        Description:      "bar",
+                        MetricNamePrefix: "/chrome/infra/",
                         Fields:           []*pb.MetricsField{},
-                        StartTimestampUs: proto.Uint64(946782245000000),
+                        StartTimestampUs: 946782245000000,
                         Task:             &pb.Task{},
-                        BooleanValue:     proto.Bool(true),
+                        BooleanValue:     true,
                 })
         })
 
         Convey("NonDefaultTarget", t, func() {
                 target := target.Task{
-                        ServiceName: proto.String("hello"),
-                        JobName:     proto.String("world"),
+                        ServiceName: "hello",
+                        JobName:     "world",
                 }
 
                 ret := SerializeCell(types.Cell{
                         types.MetricInfo{
                                 Name:        "foo",
                                 Description: "bar",
                                 Fields:      []field.Field{},
                                 ValueType:   types.NonCumulativeIntType,
                         },
                         types.CellData{
                                 FieldVals: []interface{}{},
                                 Target:    &target,
                                 ResetTime: time.Date(2000, 1, 2, 3, 4, 5, 6, time.UTC),
                                 Value:     int64(42),
                         },
                 })
                 So(ret, ShouldResemble, &pb.MetricsData{
-                        Name:             proto.String("foo"),
-                        Description:      proto.String("bar"),
-                        MetricNamePrefix: proto.String("/chrome/infra/"),
+                        Name:             "foo",
+                        Description:      "bar",
+                        MetricNamePrefix: "/chrome/infra/",
                         Fields:           []*pb.MetricsField{},
-                        StartTimestampUs: proto.Uint64(946782245000000),
+                        StartTimestampUs: 946782245000000,
                         Task: &pb.Task{
-                                ServiceName: proto.String("hello"),
-                                JobName:     proto.String("world"),
+                                ServiceName: "hello",
+                                JobName:     "world",
                         },
-                        Gauge: proto.Int64(42),
+                        Gauge: 42,
                 })
         })
 }