Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1854553002: cc: Remove fields unused now that strict property checking is always on. (Closed)

Created:
4 years, 8 months ago by benwells
Modified:
4 years, 8 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove fields unused now that strict property checking is always on. TBR=enne@chromium.org BUG=599755 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/3a513c0f094c9e81a7b88d5b6681804937dfb258 Cr-Commit-Position: refs/heads/master@{#384476}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M cc/proto/layer_tree_settings.proto View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_settings_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
benwells
4 years, 8 months ago (2016-04-01 02:27:28 UTC) #3
benwells
TBR'ing to get bot green.
4 years, 8 months ago (2016-04-01 02:31:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854553002/1
4 years, 8 months ago (2016-04-01 02:32:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 03:37:20 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3a513c0f094c9e81a7b88d5b6681804937dfb258 Cr-Commit-Position: refs/heads/master@{#384476}
4 years, 8 months ago (2016-04-01 03:39:37 UTC) #11
enne (OOO)
4 years, 8 months ago (2016-04-01 17:25:43 UTC) #12
Message was sent while issue was closed.
lgtm

Thanks for fixing my mistake.  :)

Powered by Google App Engine
This is Rietveld 408576698