content/public/android/java/src/org/chromium/content/browser/DownloadController.java - Issue 1854523002: If a download is initiated by download attribute, don't use stream viewer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/DownloadController.java

Issue 1854523002: If a download is initiated by download attribute, don't use stream viewer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ContentViewDownloadDelegate.java ('k') | content/public/browser/android/download_controller_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/DownloadController.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/DownloadController.java b/content/public/android/java/src/org/chromium/content/browser/DownloadController.java

index 5e2c29f5c47ff50edb0e41abf77545ea8bb7614c..5bc567ba0a7ea631931cadc0e15653e72bf006f1 100644

--- a/content/public/android/java/src/org/chromium/content/browser/DownloadController.java

+++ b/content/public/android/java/src/org/chromium/content/browser/DownloadController.java

@@ -80,7 +80,7 @@ public class DownloadController {

private void newHttpGetDownload(ContentViewCore view, String url,

String userAgent, String contentDisposition, String mimeType,

String cookie, String referer, boolean hasUserGesture,

- String filename, long contentLength) {

+ String filename, long contentLength, boolean mustDownload) {

ContentViewDownloadDelegate downloadDelegate = downloadDelegateFromView(view);

if (downloadDelegate == null) return;

@@ -96,7 +96,7 @@ public class DownloadController {

.setContentLength(contentLength)

.setIsGETRequest(true)

.build();

- downloadDelegate.requestHttpGetDownload(downloadInfo);

+ downloadDelegate.requestHttpGetDownload(downloadInfo, mustDownload);

}

/**