Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1669)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewDownloadDelegate.java

Issue 1854523002: If a download is initiated by download attribute, don't use stream viewer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewDownloadDelegate.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewDownloadDelegate.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewDownloadDelegate.java
index 515306260d1bc03497ab25fbf0ea5bc571108b55..7c87023fc6ac599589ec42a1834a620e803aed08 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewDownloadDelegate.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewDownloadDelegate.java
@@ -12,8 +12,12 @@ public interface ContentViewDownloadDelegate {
* Notify the host application that a file should be downloaded. Replaces
* onDownloadStart from DownloadListener.
* @param downloadInfo Information about the requested download.
+ * @param mustDownload Whether the content must be downloded. If chrome cannot resolve a MIME
+ * type, clicking a link will trigger a download. mustDownload is false if
+ * the link has no download attribute and content-disposition is not
+ * attachment.
*/
- void requestHttpGetDownload(DownloadInfo downloadInfo);
+ void requestHttpGetDownload(DownloadInfo downloadInfo, boolean mustDownload);
/**
* Notify the host application that a download is started.

Powered by Google App Engine
This is Rietveld 408576698