Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1854513002: cc: Add RasterSource::PlaybackSettings for finer control of raster. (Closed)

Created:
4 years, 8 months ago by vmpstr
Modified:
4 years, 8 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, Khushal, nyquist
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Add RasterSource::PlaybackSettings for finer control of raster. This patch adds a new settings struct that needs to be passed when we play a raster source into a canvas. This should be used for bools that affect how we raster the source. R=enne CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/3f9000d458efd36bcf829a1d0d5bcc8cd50b5ee0 Cr-Commit-Position: refs/heads/master@{#384678}

Patch Set 1 #

Patch Set 2 : nowrap #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -155 lines) Patch
M cc/debug/rasterize_and_record_benchmark_impl.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M cc/output/software_renderer.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M cc/playback/raster_source.h View 1 2 3 chunks +16 lines, -15 lines 0 comments Download
M cc/playback/raster_source.cc View 1 3 chunks +15 lines, -35 lines 0 comments Download
M cc/playback/raster_source_unittest.cc View 6 chunks +7 lines, -10 lines 0 comments Download
M cc/raster/bitmap_tile_task_worker_pool.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M cc/raster/gpu_rasterizer.h View 2 chunks +3 lines, -1 line 0 comments Download
M cc/raster/gpu_rasterizer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/raster/gpu_tile_task_worker_pool.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M cc/raster/one_copy_tile_task_worker_pool.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/raster/one_copy_tile_task_worker_pool.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M cc/raster/raster_buffer.h View 1 chunk +8 lines, -7 lines 0 comments Download
M cc/raster/tile_task_worker_pool.h View 3 chunks +11 lines, -10 lines 0 comments Download
M cc/raster/tile_task_worker_pool.cc View 3 chunks +12 lines, -11 lines 0 comments Download
M cc/raster/tile_task_worker_pool_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/raster/zero_copy_tile_task_worker_pool.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M cc/test/fake_raster_source.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_raster_source.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M cc/tiles/tile_manager.cc View 6 chunks +16 lines, -11 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
vmpstr
Please take a look.
4 years, 8 months ago (2016-03-31 23:29:08 UTC) #3
enne (OOO)
lgtm
4 years, 8 months ago (2016-04-01 00:51:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854513002/20001
4 years, 8 months ago (2016-04-01 00:58:18 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/203604)
4 years, 8 months ago (2016-04-01 06:59:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854513002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854513002/40001
4 years, 8 months ago (2016-04-01 19:05:21 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-01 20:33:37 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 20:34:58 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3f9000d458efd36bcf829a1d0d5bcc8cd50b5ee0
Cr-Commit-Position: refs/heads/master@{#384678}

Powered by Google App Engine
This is Rietveld 408576698