Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1854413002:
Search more locations for cdb.exe. (Closed)
|
Created:
4 years, 8 months ago by Ken Russell (switch to Gerrit) Modified:
4 years, 8 months ago CC:
catapult-reviews_chromium.org Base URL:
https://github.com/kenrussell/catapult.git@master Target Ref:
refs/heads/master Project:
catapult Visibility:
Public. |
DescriptionSearch more locations for cdb.exe.
The Chromium build on the bots will copy cdb.exe and its dependent
DLLs alongside the browser. Use this copy if it is available.
Otherwise, use updated locations for the executable.
BUG=chromium:561763
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/19ba6e804d68c1e6dcd8d2f5d76dc27303f26376
Patch Set 1 #Patch Set 2 : Rebased. #Patch Set 3 : Regenerated from fresh workspace. #Patch Set 4 : Put cdb and helper DLLs in a subdirectory. #Messages
Total messages: 24 (12 generated)
kbr@chromium.org changed reviewers: + nednguyen@google.com, scottmg@chromium.org
Please see https://codereview.chromium.org/1859013002/ for the companion Chromium CL that allows this copy of cdb.exe to be found. Let me know whether this approach looks acceptable. Thanks.
lgtm
The CQ bit was checked by nednguyen@google.com
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854413002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)
The CQ bit was checked by kbr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com, scottmg@chromium.org Link to the patchset: https://codereview.chromium.org/1854413002/#ps20001 (title: "Rebased.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854413002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)
The CQ bit was checked by kbr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com, scottmg@chromium.org Link to the patchset: https://codereview.chromium.org/1854413002/#ps40001 (title: "Regenerated from fresh workspace.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854413002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854413002/40001
On 2016/04/05 23:04:38, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > https://chromium-cq-status.appspot.com/patch-status/1854413002/40001 > View timeline at > https://chromium-cq-status.appspot.com/patch-timeline/1854413002/40001 I'm going to include another change in this CL.
The CQ bit was unchecked by kbr@chromium.org
It was necessary to put cdb.exe and its helper DLLs into a subdirectory: first, because of collisions with another copy of dbghelp.dll copied there by base/ which scottmg's in the process of removing; and second, to avoid adding a problematic implicit dependency. scottmg and I talked this over and I hope it's non-controversial. CQ'ing.
The CQ bit was checked by kbr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com, scottmg@chromium.org Link to the patchset: https://codereview.chromium.org/1854413002/#ps60001 (title: "Put cdb and helper DLLs in a subdirectory.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854413002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854413002/60001
Message was sent while issue was closed.
Description was changed from ========== Search more locations for cdb.exe. The Chromium build on the bots will copy cdb.exe and its dependent DLLs alongside the browser. Use this copy if it is available. Otherwise, use updated locations for the executable. BUG=chromium:561763 ========== to ========== Search more locations for cdb.exe. The Chromium build on the bots will copy cdb.exe and its dependent DLLs alongside the browser. Use this copy if it is available. Otherwise, use updated locations for the executable. BUG=chromium:561763 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu... |
