Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py

Issue 1854413002: Search more locations for cdb.exe. (Closed) Base URL: https://github.com/kenrussell/catapult.git@master
Patch Set: Put cdb and helper DLLs in a subdirectory. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py
diff --git a/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py b/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py
index d23c626e55817cd6244cd9f2d610bf33a11a5880..8351de547818b7dcdb65237fb048419cd4354091 100644
--- a/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py
+++ b/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py
@@ -206,12 +206,22 @@ class DesktopBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):
return os.path.join(self.profile_directory, 'DevToolsActivePort')
def _GetCdbPath(self):
+ # cdb.exe might have been co-located with the browser's executable
+ # during the build, but that's not a certainty. (This is only done
+ # in Chromium builds on the bots, which is why it's not a hard
+ # requirement.) See if it's available.
+ colocated_cdb = os.path.join(self._browser_directory, 'cdb', 'cdb.exe')
+ if path.IsExecutable(colocated_cdb):
+ return colocated_cdb
possible_paths = (
+ # Installed copies of the Windows SDK.
+ os.path.join('Windows Kits', '*', 'Debuggers', 'x86'),
+ os.path.join('Windows Kits', '*', 'Debuggers', 'x64'),
+ # Old copies of the Debugging Tools for Windows.
'Debugging Tools For Windows',
'Debugging Tools For Windows (x86)',
'Debugging Tools For Windows (x64)',
- os.path.join('Windows Kits', '8.0', 'Debuggers', 'x86'),
- os.path.join('Windows Kits', '8.0', 'Debuggers', 'x64'),
+ # The hermetic copy of the Windows toolchain in depot_tools.
os.path.join('win_toolchain', 'vs_files', '*', 'win_sdk',
'Debuggers', 'x86'),
os.path.join('win_toolchain', 'vs_files', '*', 'win_sdk',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698