Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(130)

Issue 1854333002: give up if huge paths have unresolvable coincidence (Closed)

Created:
3 years, 3 months ago by caryclark
Modified:
3 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

give up if huge paths have unresolvable coincidence This fuzzy test has enormous curves with coincidence runs that break numerics. If the computed intersections identify that the span of coincidence has been deleted, give up and return that the path op failed. TBR=reed@google.com BUG=597926 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1854333002 Committed: https://skia.googlesource.com/skia/+/5c5cfe24efe4c728e787447dabffe345080d1fb9

Patch Set 1 #

Patch Set 2 : give up if huge paths have unresolvable coincidences #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -4 lines) Patch
M src/pathops/SkOpCoincidence.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkOpCoincidence.cpp View 1 2 chunks +9 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsCommon.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download
M tests/PathOpsOpTest.cpp View 1 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854333002/20001
3 years, 3 months ago (2016-04-05 14:06:07 UTC) #6
commit-bot: I haz the power
3 years, 3 months ago (2016-04-05 14:28:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5c5cfe24efe4c728e787447dabffe345080d1fb9

Powered by Google App Engine
This is Rietveld 408576698