Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1854323002:
[Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE for child processes. (Closed)
|
Created:
4 years, 8 months ago by penny Modified:
4 years, 4 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org, caitkp+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE for child processes.
This CL is part of a chain of CLs:
1) "MITIGATION_EXTENSION_POINT_DISABLE support for children" (https://codereview.chromium.org/1835003003)
2) "MITIGATION_EXTENSION_POINT_DISABLE emergency off finch" (https://codereview.chromium.org/1836523004/)
3) "New NT registry API" (https://codereview.chromium.org/1841573002)
4) "Early browser security support" (https://codereview.chromium.org/1656453002)
5) -> THIS
6) "Turn on MITIGATION_EXTENSION_POINT_DISABLE for browser process" (https://codereview.chromium.org/2223783003)
This CL only turns on the new mitigation (in all child processes, not the browser process yet).
BUG=557798
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Committed: https://crrev.com/df585142df9fd58299ef02b64da3381d8b733cb8
Committed: https://crrev.com/3087cbe87c1d2cd8a43c55d8ed4d7bbe2d9d9609
Cr-Original-Commit-Position: refs/heads/master@{#409264}
Cr-Commit-Position: refs/heads/master@{#410508}
Patch Set 1 #Patch Set 2 : Added comment. #Patch Set 3 : Tiny comment change - stop using "we/our". #Patch Set 4 : Moving this CL over to new branch. Also, updated with latest trunk. #Patch Set 5 : Update for install_static namespace. #Patch Set 6 : Seem to have x86 GN build working. Needed content_features for linking. #Patch Set 7 : Remove DISABLE_EXTENSION_POINT for browser process - until IME support can be fixed. #
Messages
Total messages: 57 (38 generated)
Description was changed from ========== [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE. This CL is part of a chain of CLs: 1) "MITIGATION_EXTENSION_POINT_DISABLE support for children" (https://codereview.chromium.org/1835003003) 2) "MITIGATION_EXTENSION_POINT_DISABLE emergency off finch" (https://codereview.chromium.org/1836523004/) 3) "New NT registry API" (https://codereview.chromium.org/1841573002) 4) "Early browser security support" () -> THIS This CL only turns on the new mitigation (in all child processes, and early for the browser process). BUG=557798 ========== to ========== [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE. This CL is part of a chain of CLs: 1) "MITIGATION_EXTENSION_POINT_DISABLE support for children" (https://codereview.chromium.org/1835003003) 2) "MITIGATION_EXTENSION_POINT_DISABLE emergency off finch" (https://codereview.chromium.org/1836523004/) 3) "New NT registry API" (https://codereview.chromium.org/1841573002) 4) "Early browser security support" (https://codereview.chromium.org/1656453002) -> THIS This CL only turns on the new mitigation (in all child processes, and early for the browser process). BUG=557798 ==========
pennymac@chromium.org changed reviewers: + robertshield@chromium.org, wfh@chromium.org
Hello, This is the final CL that will actually turn on MITIGATION_EXTENSION_POINT_DISABLE. There's no try bot run yet, as I'll wait for CL #4 to land first, and then update this branch. (Note that I did run tests successfully with this locally - with all CLs together.) Thanks!
content/common/sandbox_win.cc lgtm
lgtm
pennymac@chromium.org changed reviewers: + nick@chromium.org
The CQ bit was checked by pennymac@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
Description was changed from ========== [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE. This CL is part of a chain of CLs: 1) "MITIGATION_EXTENSION_POINT_DISABLE support for children" (https://codereview.chromium.org/1835003003) 2) "MITIGATION_EXTENSION_POINT_DISABLE emergency off finch" (https://codereview.chromium.org/1836523004/) 3) "New NT registry API" (https://codereview.chromium.org/1841573002) 4) "Early browser security support" (https://codereview.chromium.org/1656453002) -> THIS This CL only turns on the new mitigation (in all child processes, and early for the browser process). BUG=557798 ========== to ========== [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE. This CL is part of a chain of CLs: 1) "MITIGATION_EXTENSION_POINT_DISABLE support for children" (https://codereview.chromium.org/1835003003) 2) "MITIGATION_EXTENSION_POINT_DISABLE emergency off finch" (https://codereview.chromium.org/1836523004/) 3) "New NT registry API" (https://codereview.chromium.org/1841573002) 4) "Early browser security support" (https://codereview.chromium.org/1656453002) -> THIS This CL only turns on the new mitigation (in all child processes, and early for the browser process). BUG=557798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng ==========
content lgtm
Patchset #6 (id:100001) has been deleted
Patchset #6 (id:120001) has been deleted
Patchset #7 (id:160001) has been deleted
Patchset #6 (id:140001) has been deleted
Patchset #6 (id:180001) has been deleted
Description was changed from ========== [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE. This CL is part of a chain of CLs: 1) "MITIGATION_EXTENSION_POINT_DISABLE support for children" (https://codereview.chromium.org/1835003003) 2) "MITIGATION_EXTENSION_POINT_DISABLE emergency off finch" (https://codereview.chromium.org/1836523004/) 3) "New NT registry API" (https://codereview.chromium.org/1841573002) 4) "Early browser security support" (https://codereview.chromium.org/1656453002) -> THIS This CL only turns on the new mitigation (in all child processes, and early for the browser process). BUG=557798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng ========== to ========== [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE. This CL is part of a chain of CLs: 1) "MITIGATION_EXTENSION_POINT_DISABLE support for children" (https://codereview.chromium.org/1835003003) 2) "MITIGATION_EXTENSION_POINT_DISABLE emergency off finch" (https://codereview.chromium.org/1836523004/) 3) "New NT registry API" (https://codereview.chromium.org/1841573002) 4) "Early browser security support" (https://codereview.chromium.org/1656453002) -> THIS This CL only turns on the new mitigation (in all child processes, and early for the browser process). BUG=557798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng ==========
pennymac@chromium.org changed reviewers: + bradnelson@chromium.org, dschuff@chromium.org
Hello Brad and Derek, Could one of you please review my changes to the GN files? nacl64 was failing to link sandbox_win.obj, due to the new use of content_features in content/common/sandbox_win.cc. Link was of course only failing on x86 Windows builds (nacl64). I added a source_set like static_switches, for static_features, and now depend on it from nacl64 (like static_switches). Please let me know if you think there is a cleaner GN change. Thanks for your time!
The CQ bit was checked by pennymac@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
bradnelson@google.com changed reviewers: + bradnelson@google.com
lgtm
pennymac@chromium.org changed reviewers: - dschuff@chromium.org
The CQ bit was checked by pennymac@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from robertshield@chromium.org, wfh@chromium.org, nick@chromium.org Link to the patchset: https://codereview.chromium.org/1854323002/#ps200001 (title: "Seem to have x86 GN build working. Needed content_features for linking.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
On 2016/08/02 18:32:51, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) Hi Brad, You're in the owners file as bradnelson@, not bradn. Any way you can lgtm from that account name?
The CQ bit was checked by bradnelson@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE. This CL is part of a chain of CLs: 1) "MITIGATION_EXTENSION_POINT_DISABLE support for children" (https://codereview.chromium.org/1835003003) 2) "MITIGATION_EXTENSION_POINT_DISABLE emergency off finch" (https://codereview.chromium.org/1836523004/) 3) "New NT registry API" (https://codereview.chromium.org/1841573002) 4) "Early browser security support" (https://codereview.chromium.org/1656453002) -> THIS This CL only turns on the new mitigation (in all child processes, and early for the browser process). BUG=557798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng ========== to ========== [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE. This CL is part of a chain of CLs: 1) "MITIGATION_EXTENSION_POINT_DISABLE support for children" (https://codereview.chromium.org/1835003003) 2) "MITIGATION_EXTENSION_POINT_DISABLE emergency off finch" (https://codereview.chromium.org/1836523004/) 3) "New NT registry API" (https://codereview.chromium.org/1841573002) 4) "Early browser security support" (https://codereview.chromium.org/1656453002) -> THIS This CL only turns on the new mitigation (in all child processes, and early for the browser process). BUG=557798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng ==========
Message was sent while issue was closed.
Committed patchset #6 (id:200001)
Message was sent while issue was closed.
Description was changed from ========== [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE. This CL is part of a chain of CLs: 1) "MITIGATION_EXTENSION_POINT_DISABLE support for children" (https://codereview.chromium.org/1835003003) 2) "MITIGATION_EXTENSION_POINT_DISABLE emergency off finch" (https://codereview.chromium.org/1836523004/) 3) "New NT registry API" (https://codereview.chromium.org/1841573002) 4) "Early browser security support" (https://codereview.chromium.org/1656453002) -> THIS This CL only turns on the new mitigation (in all child processes, and early for the browser process). BUG=557798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng ========== to ========== [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE. This CL is part of a chain of CLs: 1) "MITIGATION_EXTENSION_POINT_DISABLE support for children" (https://codereview.chromium.org/1835003003) 2) "MITIGATION_EXTENSION_POINT_DISABLE emergency off finch" (https://codereview.chromium.org/1836523004/) 3) "New NT registry API" (https://codereview.chromium.org/1841573002) 4) "Early browser security support" (https://codereview.chromium.org/1656453002) -> THIS This CL only turns on the new mitigation (in all child processes, and early for the browser process). BUG=557798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Committed: https://crrev.com/df585142df9fd58299ef02b64da3381d8b733cb8 Cr-Commit-Position: refs/heads/master@{#409264} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/df585142df9fd58299ef02b64da3381d8b733cb8 Cr-Commit-Position: refs/heads/master@{#409264}
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:200001) has been created in https://codereview.chromium.org/2227453002/ by pennymac@chromium.org. The reason for reverting is: Reverting the "on switch" temporarily. Want to look at the scope/details of broken IMEs more before re-landing. What percentage of Chrome IMEs are actually still using legacy hooking techniques to inject DLLs into our processes? Ref: https://bugs.chromium.org/p/chromium/issues/detail?id=634192.
Message was sent while issue was closed.
Description was changed from ========== [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE. This CL is part of a chain of CLs: 1) "MITIGATION_EXTENSION_POINT_DISABLE support for children" (https://codereview.chromium.org/1835003003) 2) "MITIGATION_EXTENSION_POINT_DISABLE emergency off finch" (https://codereview.chromium.org/1836523004/) 3) "New NT registry API" (https://codereview.chromium.org/1841573002) 4) "Early browser security support" (https://codereview.chromium.org/1656453002) -> THIS This CL only turns on the new mitigation (in all child processes, and early for the browser process). BUG=557798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Committed: https://crrev.com/df585142df9fd58299ef02b64da3381d8b733cb8 Cr-Commit-Position: refs/heads/master@{#409264} ========== to ========== [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE. This CL is part of a chain of CLs: 1) "MITIGATION_EXTENSION_POINT_DISABLE support for children" (https://codereview.chromium.org/1835003003) 2) "MITIGATION_EXTENSION_POINT_DISABLE emergency off finch" (https://codereview.chromium.org/1836523004/) 3) "New NT registry API" (https://codereview.chromium.org/1841573002) 4) "Early browser security support" (https://codereview.chromium.org/1656453002) -> THIS This CL only turns on the new mitigation (in all child processes, and early for the browser process). BUG=557798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Committed: https://crrev.com/df585142df9fd58299ef02b64da3381d8b733cb8 Cr-Commit-Position: refs/heads/master@{#409264} ==========
Patchset #8 (id:240001) has been deleted
Patchset #7 (id:220001) has been deleted
Description was changed from ========== [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE. This CL is part of a chain of CLs: 1) "MITIGATION_EXTENSION_POINT_DISABLE support for children" (https://codereview.chromium.org/1835003003) 2) "MITIGATION_EXTENSION_POINT_DISABLE emergency off finch" (https://codereview.chromium.org/1836523004/) 3) "New NT registry API" (https://codereview.chromium.org/1841573002) 4) "Early browser security support" (https://codereview.chromium.org/1656453002) -> THIS This CL only turns on the new mitigation (in all child processes, and early for the browser process). BUG=557798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Committed: https://crrev.com/df585142df9fd58299ef02b64da3381d8b733cb8 Cr-Commit-Position: refs/heads/master@{#409264} ========== to ========== [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE for child processes. This CL is part of a chain of CLs: 1) "MITIGATION_EXTENSION_POINT_DISABLE support for children" (https://codereview.chromium.org/1835003003) 2) "MITIGATION_EXTENSION_POINT_DISABLE emergency off finch" (https://codereview.chromium.org/1836523004/) 3) "New NT registry API" (https://codereview.chromium.org/1841573002) 4) "Early browser security support" (https://codereview.chromium.org/1656453002) -> THIS 5) "Turn on MITIGATION_EXTENSION_POINT_DISABLE for browser process" This CL only turns on the new mitigation (in all child processes, not the browser process yet). BUG=557798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Committed: https://crrev.com/df585142df9fd58299ef02b64da3381d8b733cb8 Cr-Commit-Position: refs/heads/master@{#409264} ==========
Description was changed from ========== [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE for child processes. This CL is part of a chain of CLs: 1) "MITIGATION_EXTENSION_POINT_DISABLE support for children" (https://codereview.chromium.org/1835003003) 2) "MITIGATION_EXTENSION_POINT_DISABLE emergency off finch" (https://codereview.chromium.org/1836523004/) 3) "New NT registry API" (https://codereview.chromium.org/1841573002) 4) "Early browser security support" (https://codereview.chromium.org/1656453002) -> THIS 5) "Turn on MITIGATION_EXTENSION_POINT_DISABLE for browser process" This CL only turns on the new mitigation (in all child processes, not the browser process yet). BUG=557798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Committed: https://crrev.com/df585142df9fd58299ef02b64da3381d8b733cb8 Cr-Commit-Position: refs/heads/master@{#409264} ========== to ========== [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE for child processes. This CL is part of a chain of CLs: 1) "MITIGATION_EXTENSION_POINT_DISABLE support for children" (https://codereview.chromium.org/1835003003) 2) "MITIGATION_EXTENSION_POINT_DISABLE emergency off finch" (https://codereview.chromium.org/1836523004/) 3) "New NT registry API" (https://codereview.chromium.org/1841573002) 4) "Early browser security support" (https://codereview.chromium.org/1656453002) 5) -> THIS 6) "Turn on MITIGATION_EXTENSION_POINT_DISABLE for browser process" (https://codereview.chromium.org/2223783003) This CL only turns on the new mitigation (in all child processes, not the browser process yet). BUG=557798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Committed: https://crrev.com/df585142df9fd58299ef02b64da3381d8b733cb8 Cr-Commit-Position: refs/heads/master@{#409264} ==========
The CQ bit was checked by pennymac@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nick@chromium.org, bradnelson@chromium.org, robertshield@chromium.org, bradnelson@google.com, wfh@chromium.org Link to the patchset: https://codereview.chromium.org/1854323002/#ps260001 (title: "Remove DISABLE_EXTENSION_POINT for browser process - until IME support can be fixed.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by pennymac@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE for child processes. This CL is part of a chain of CLs: 1) "MITIGATION_EXTENSION_POINT_DISABLE support for children" (https://codereview.chromium.org/1835003003) 2) "MITIGATION_EXTENSION_POINT_DISABLE emergency off finch" (https://codereview.chromium.org/1836523004/) 3) "New NT registry API" (https://codereview.chromium.org/1841573002) 4) "Early browser security support" (https://codereview.chromium.org/1656453002) 5) -> THIS 6) "Turn on MITIGATION_EXTENSION_POINT_DISABLE for browser process" (https://codereview.chromium.org/2223783003) This CL only turns on the new mitigation (in all child processes, not the browser process yet). BUG=557798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Committed: https://crrev.com/df585142df9fd58299ef02b64da3381d8b733cb8 Cr-Commit-Position: refs/heads/master@{#409264} ========== to ========== [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE for child processes. This CL is part of a chain of CLs: 1) "MITIGATION_EXTENSION_POINT_DISABLE support for children" (https://codereview.chromium.org/1835003003) 2) "MITIGATION_EXTENSION_POINT_DISABLE emergency off finch" (https://codereview.chromium.org/1836523004/) 3) "New NT registry API" (https://codereview.chromium.org/1841573002) 4) "Early browser security support" (https://codereview.chromium.org/1656453002) 5) -> THIS 6) "Turn on MITIGATION_EXTENSION_POINT_DISABLE for browser process" (https://codereview.chromium.org/2223783003) This CL only turns on the new mitigation (in all child processes, not the browser process yet). BUG=557798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Committed: https://crrev.com/df585142df9fd58299ef02b64da3381d8b733cb8 Cr-Commit-Position: refs/heads/master@{#409264} ==========
Message was sent while issue was closed.
Committed patchset #7 (id:260001)
Message was sent while issue was closed.
Description was changed from ========== [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE for child processes. This CL is part of a chain of CLs: 1) "MITIGATION_EXTENSION_POINT_DISABLE support for children" (https://codereview.chromium.org/1835003003) 2) "MITIGATION_EXTENSION_POINT_DISABLE emergency off finch" (https://codereview.chromium.org/1836523004/) 3) "New NT registry API" (https://codereview.chromium.org/1841573002) 4) "Early browser security support" (https://codereview.chromium.org/1656453002) 5) -> THIS 6) "Turn on MITIGATION_EXTENSION_POINT_DISABLE for browser process" (https://codereview.chromium.org/2223783003) This CL only turns on the new mitigation (in all child processes, not the browser process yet). BUG=557798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Committed: https://crrev.com/df585142df9fd58299ef02b64da3381d8b733cb8 Cr-Commit-Position: refs/heads/master@{#409264} ========== to ========== [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE for child processes. This CL is part of a chain of CLs: 1) "MITIGATION_EXTENSION_POINT_DISABLE support for children" (https://codereview.chromium.org/1835003003) 2) "MITIGATION_EXTENSION_POINT_DISABLE emergency off finch" (https://codereview.chromium.org/1836523004/) 3) "New NT registry API" (https://codereview.chromium.org/1841573002) 4) "Early browser security support" (https://codereview.chromium.org/1656453002) 5) -> THIS 6) "Turn on MITIGATION_EXTENSION_POINT_DISABLE for browser process" (https://codereview.chromium.org/2223783003) This CL only turns on the new mitigation (in all child processes, not the browser process yet). BUG=557798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Committed: https://crrev.com/df585142df9fd58299ef02b64da3381d8b733cb8 Committed: https://crrev.com/3087cbe87c1d2cd8a43c55d8ed4d7bbe2d9d9609 Cr-Original-Commit-Position: refs/heads/master@{#409264} Cr-Commit-Position: refs/heads/master@{#410508} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/3087cbe87c1d2cd8a43c55d8ed4d7bbe2d9d9609 Cr-Commit-Position: refs/heads/master@{#410508} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
