content/common/sandbox_win.cc - Issue 1854323002: [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE for child processes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/sandbox_win.cc

Issue 1854323002: [Windows Sandbox] Turn on MITIGATION_EXTENSION_POINT_DISABLE for child processes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove DISABLE_EXTENSION_POINT for browser process - until IME support can be fixed. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/sandbox_win.cc

diff --git a/content/common/sandbox_win.cc b/content/common/sandbox_win.cc

index e3b8f7defd64ea2af8e0e0c1232387481a8a4f01..2cd1e9c32ca8233f51efe021dc44fe59d5124a0f 100644

--- a/content/common/sandbox_win.cc

+++ b/content/common/sandbox_win.cc

@@ -31,6 +31,7 @@

#include "base/win/windows_version.h"

#include "content/common/content_switches_internal.h"

#include "content/public/common/content_client.h"

+#include "content/public/common/content_features.h"

#include "content/public/common/content_switches.h"

#include "content/public/common/sandbox_init.h"

#include "content/public/common/sandboxed_process_launcher_delegate.h"

@@ -724,8 +725,10 @@ sandbox::ResultCode StartSandboxedProcess(

sandbox::MITIGATION_IMAGE_LOAD_NO_REMOTE |

sandbox::MITIGATION_IMAGE_LOAD_NO_LOW_LABEL;

- sandbox::ResultCode result = sandbox::SBOX_ERROR_GENERIC;

+ if (base::FeatureList::IsEnabled(features::kWinSboxDisableExtensionPoints))

+ mitigations |= sandbox::MITIGATION_EXTENSION_POINT_DISABLE;

+ sandbox::ResultCode result = sandbox::SBOX_ERROR_GENERIC;

result = policy->SetProcessMitigations(mitigations);

if (result != sandbox::SBOX_ALL_OK)

« no previous file with comments | « content/app/sandbox_helper_win.cc ('k') | content/public/common/BUILD.gn » ('j') | no next file with comments »