Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1854233002: Reland 2 of GN: Make breakpad_unittests & sandbox_linux_unittests use test() (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@test-minor-renames
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland 2 of GN: Make breakpad_unittests & sandbox_linux_unittests use test() This simplifies build rules for native tests, and allows us to get rid of ${target}_deps targets (once recipes are updated). This change fixes the generated wrapper scripts, which didn't work. TBR=jbudorick BUG=589318 Committed: https://crrev.com/62ab0028a0165eecd60568783531d1ad3d031a26 Cr-Commit-Position: refs/heads/master@{#385084}

Patch Set 1 #

Patch Set 2 : Fix PIE errors, fix component mode. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -253 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M breakpad/BUILD.gn View 1 3 chunks +4 lines, -26 lines 0 comments Download
M breakpad/breakpad.gyp View 1 1 chunk +6 lines, -7 lines 0 comments Download
M build/android/native_app_dependencies.gypi View 1 2 chunks +9 lines, -0 lines 0 comments Download
M build/android/pylib/gtest/gtest_test_instance.py View 1 3 chunks +14 lines, -7 lines 0 comments Download
M build/android/pylib/local/device/local_device_gtest_run.py View 1 3 chunks +12 lines, -20 lines 0 comments Download
M build/android/test_runner.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 1 chunk +15 lines, -5 lines 0 comments Download
M build/config/android/rules.gni View 1 3 chunks +23 lines, -37 lines 0 comments Download
M sandbox/linux/BUILD.gn View 1 2 chunks +6 lines, -37 lines 0 comments Download
M sandbox/linux/sandbox_linux.gypi View 1 1 chunk +4 lines, -18 lines 0 comments Download
M testing/test.gni View 1 1 chunk +117 lines, -93 lines 0 comments Download
M tools/android/forwarder2/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/android/md5sum/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
agrieve
Created Reland of GN: Make breakpad_unittests & sandbox_linux_unittests use test()
4 years, 8 months ago (2016-04-04 19:28:53 UTC) #1
agrieve
yfriedman for tools/android
4 years, 8 months ago (2016-04-04 19:31:31 UTC) #3
agrieve
4 years, 8 months ago (2016-04-04 19:31:56 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854233002/170001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854233002/170001
4 years, 8 months ago (2016-04-04 19:32:33 UTC) #7
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-04 19:36:56 UTC) #8
Yaron
lgtm
4 years, 8 months ago (2016-04-04 19:39:04 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-04 21:47:27 UTC) #11
agrieve
On 2016/04/04 21:47:27, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 8 months ago (2016-04-05 01:56:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854233002/170001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854233002/170001
4 years, 8 months ago (2016-04-05 01:57:08 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:170001)
4 years, 8 months ago (2016-04-05 02:03:54 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 02:04:54 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/62ab0028a0165eecd60568783531d1ad3d031a26
Cr-Commit-Position: refs/heads/master@{#385084}

Powered by Google App Engine
This is Rietveld 408576698