Reland 2 of GN: Make breakpad_unittests & sandbox_linux_unittests use test()

breakpad/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/symlink.gni")
 import("//testing/test.gni")
 
 if (is_android) {
   import("//build/config/android/rules.gni")
 }
@@ skipping 605 matching lines @@
       "src/client",
       "src/third_party/linux/include",
       ".",
     ]
 
     # There are some warnings in this code.
     configs -= [ "//build/config/compiler:chromium_code" ]
     configs += [ "//build/config/compiler:no_chromium_code" ]
   }
 
-  # "breakpad_unittests" cannot use the test() template because the test is run
-  # as an executable not as an APK on Android.
-  executable("breakpad_unittests") {
-    testonly = true
+  test("breakpad_unittests") {
     set_sources_assignment_filter([])
     sources = [
       "linux/breakpad_googletest_includes.h",
       "src/client/linux/handler/exception_handler_unittest.cc",
       "src/client/linux/minidump_writer/cpu_set_unittest.cc",
       "src/client/linux/minidump_writer/directory_reader_unittest.cc",
       "src/client/linux/minidump_writer/line_reader_unittest.cc",
       "src/client/linux/minidump_writer/linux_core_dumper_unittest.cc",
       "src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc",
       "src/client/linux/minidump_writer/minidump_writer_unittest.cc",
@@ skipping 35 matching lines @@
     # There are some warnings in this code.
     configs -= [ "//build/config/compiler:chromium_code" ]
     configs += [ "//build/config/compiler:no_chromium_code" ]
 
     if (is_clang) {
       # See http://crbug.com/138571#c18
       cflags = [ "-Wno-unused-value" ]
     }
 
     if (is_android) {
+      use_raw_android_executable = true
       sources += [ "src/common/android/breakpad_getcontext_unittest.cc" ]
       libs = [ "log" ]
       include_dirs += [ "src/common/android/include" ]
+      extra_dist_files = [ "$root_out_dir/linux_dumper_unittest_helper" ]
     }
 
     # Clang's -mstackrealign doesn't work well with
     # linux_syscall_support.h hand written asm syscalls.
     # See https://crbug.com/556393
     configs -= [ "//build/config/compiler:clang_stackrealign" ]
   }
 
   executable("linux_dumper_unittest_helper") {
     set_sources_assignment_filter([])
@@ skipping 179 matching lines @@
       "src/client/windows/sender/crash_report_sender.h",
       "src/common/windows/http_upload.cc",
       "src/common/windows/http_upload.h",
     ]
     configs += [ ":sender_config" ]
     public_configs = [ ":sender_config" ]
   }
 }
 
 if (is_android) {
-  create_native_executable_dist("breakpad_unittests_deps") {
-    testonly = true
-    dist_dir = "$root_out_dir/breakpad_unittests_deps"
-    binary = "$root_out_dir/breakpad_unittests"
-    deps = [
-      ":breakpad_unittests",
-    ]
-
-    if (is_component_build) {
-      deps += [ "//build/android:cpplib_stripped" ]
-    }
-  }
-
-  test_runner_script("breakpad_unittests__test_runner_script") {
-    test_name = "breakpad_unittests"
-    test_type = "gtest"
-    test_suite = "breakpad_unittests"
-    isolate_file = "breakpad_unittests.isolate"
-  }
-
   # TODO(GYP) Delete this after we've converted everything to GN.
-  # The _run targets exist only for compatibility w/ GYP.
-  group("breakpad_unittests_apk_run") {
+  group("breakpad_unittests_deps") {
     testonly = true
     deps = [
       ":breakpad_unittests",
     ]
   }
 }