Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/strings/string_piece_unittest.cc

Issue 185423006: Eliminate build warnings in base/ for Android x64 (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/debug/stack_trace_android.cc ('K') | « base/os_compat_android.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/strings/string_piece_unittest.cc
===================================================================
--- base/strings/string_piece_unittest.cc (revision 254431)
+++ base/strings/string_piece_unittest.cc (working copy)
@@ -664,9 +664,11 @@
ASSERT_TRUE(str == BasicStringPiece<TypeParam>(str.c_str()));
ASSERT_TRUE(TestFixture::as_string("hello") ==
BasicStringPiece<TypeParam>(str.c_str(), 5));
- ASSERT_TRUE(empty == BasicStringPiece<TypeParam>(str.c_str(), 0U));
+ ASSERT_TRUE(empty == BasicStringPiece<TypeParam>(str.c_str(),
+ static_cast<typename BasicStringPiece<TypeParam>::size_type>(0)));
bulach 2014/03/03 09:15:41 nit: indent by another 2 spaces (and in 671 below
ASSERT_TRUE(empty == BasicStringPiece<TypeParam>(NULL));
- ASSERT_TRUE(empty == BasicStringPiece<TypeParam>(NULL, 0U));
+ ASSERT_TRUE(empty == BasicStringPiece<TypeParam>(NULL,
+ static_cast<typename BasicStringPiece<TypeParam>::size_type>(0)));
ASSERT_TRUE(empty == BasicStringPiece<TypeParam>());
ASSERT_TRUE(str == BasicStringPiece<TypeParam>(str.begin(), str.end()));
ASSERT_TRUE(empty == BasicStringPiece<TypeParam>(str.begin(), str.begin()));
« base/debug/stack_trace_android.cc ('K') | « base/os_compat_android.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698