Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4290)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/debug/stack_trace_android.cc

Issue 185423006: Eliminate build warnings in base/ for Android x64 (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/debug/proc_maps_linux.cc ('K') | « base/debug/proc_maps_linux.cc ('k') | base/os_compat_android.cc » ('j') | base/strings/string_piece_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/stack_trace_android.cc
===================================================================
--- base/debug/stack_trace_android.cc (revision 254431)
+++ base/debug/stack_trace_android.cc (working copy)
@@ -104,12 +104,17 @@
++iter;
}
- *os << base::StringPrintf("#%02d 0x%08x ", i, address);
+#ifdef __LP64__
bulach 2014/03/03 09:15:41 nit: similarly to the previous file, please move t
+#define FMT_ADDR "0x%016lx"
+#else
+#define FMT_ADDR "0x%08x"
+#endif
+ *os << base::StringPrintf("#%02zd " FMT_ADDR " ", i, address);
if (iter != regions.end()) {
uintptr_t rel_pc = address - iter->start + iter->offset;
const char* path = iter->path.c_str();
- *os << base::StringPrintf("%s+0x%08x", path, rel_pc);
+ *os << base::StringPrintf("%s+" FMT_ADDR, path, rel_pc);
} else {
*os << "<unknown>";
}
« base/debug/proc_maps_linux.cc ('K') | « base/debug/proc_maps_linux.cc ('k') | base/os_compat_android.cc » ('j') | base/strings/string_piece_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698